On Mon, Nov 21, 2022 at 4:04 PM Frode Nordahl <frode.nord...@canonical.com> wrote: > > > > On Mon, Nov 21, 2022 at 3:45 PM Chet Ramey <chet.ra...@case.edu> wrote: >> >> On 11/19/22 3:08 PM, Frode Nordahl wrote: >> >> >>> For some reason, when the 'ovn-controller incremental processing' test is >> >>> executed using bash 5.2 on Debian experimental or Ubuntu Kinetic/Lunar, >> >>> the >> >>> `eval` [0] in the `counter_delta_` function misinterprets successful >> >>> execution >> >>> of commands [1], leading to a false negative for the 'ovn-controller >> >>> incremental processing' test [2]. >> >> >> >> Can you enable -x around these commands so we can at least see what the >> >> commands are, and maybe synthesize a reproducer from that? >> > >> > Sure, the command string itself looks like this: >> > >> > +++++ eval 'ovn-nbctl --wait=hv lrp-set-gateway-chassis lr1-public hv3 >> > 30 && ovn-nbctl --wait=hv sync >> >> Thanks. I was able to put together a small reproducer. The issue was the >> interaction between `eval' and a (command) subshell earlier in the script. >> >> If your fix works for you, go with it. I have somthing from a slightly >> different angle that I think will work as well. > > > Excellent, thank you for looking into it! > > As I'm not intimately familiar with the bash code base, the main reason for > providing the proposed revert/fix was to help point in the direction of where > the problem might be. > > We've worked around the concrete issue we had for now by disabling said test, > and would have no issue with waiting for a proper fix. > > -- > Frode Nordahl
Just wanted to mention that the fix in https://git.savannah.gnu.org/cgit/bash.git/commit/?h=devel&id=94d25f57f124a9b2268a3af0a0915871032f426e does indeed solve the issue for me. Thank you for the proper fix and credits for the bug report. Cheers! -- Frode Nordahl
