On 2/6/19 7:02 PM, Dennis Clarke wrote:
>
> Just a minor nit.
>
> The examples file fdflags.c uses flag O_CLOEXEC which of course does not
> exist on Solaris or any linux previous to 2.6.23 so of course install
> blows up a bit. Trivial hack solution is I remove fdflags from the
> examples install phase and life goes on neatly.
I guess Solaris (version?) doesn't implement the version of POSIX that has
O_CLOEXEC defined. I think that's the 2008 version, Issue 7.
> Most likely we need a check for the existence of O_CLOEXEC during the
> configure stage and then adjust ./examples/loadables/Makefile.in to
> remove or skip the example file.
The purpose of the builtin is to query and set the file descriptor flags
the system supports, and those flags are the ones defined for open(2), so
we really need to use O_CLOEXEC if it's available and skip it if it's not.
I'll see about making those changes for the next devel branch push.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU c...@case.edu http://tiswww.cwru.edu/~chet/
