Hi,

Test run-new-exp maybe fail when run as root, but not real fail,

detail please see the attached patch.

Version info: Bash 4.4.18



--
BRs

Sandy(Li Changqing)

>From 87a5bb56391fa6f2cd2604e01d5b6b5d6142fcb3 Mon Sep 17 00:00:00 2001
From: Changqing Li <changqing...@windriver.com>
Date: Fri, 23 Nov 2018 09:50:26 +0800
Subject: [PATCH] run-new-exp: add a warning of not real failure

run-new-exp test fail when run as root user,  but not fail
as non-root user. since in new-exp.right, we use $ as prompt,
but for root. it is #, this is not a real fail. Maybe also
should add a warning here

Signed-off-by: Changqing Li <changqing...@windriver.com>
---
 tests/run-new-exp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/run-new-exp b/tests/run-new-exp
index 8777c7b..d3ae5e0 100644
--- a/tests/run-new-exp
+++ b/tests/run-new-exp
@@ -5,6 +5,9 @@ echo "warning: this a test failure" >&2
 echo "warning: if you have exported variables beginning with the string _Q," >&2
 echo "warning: diff output may be generated.  If so, please do not consider" >&2
 echo "warning: this a test failure" >&2
+echo "warning: Beside above 2 tests, another test maybe fail if your run test" >&2
+echo "warning: as root user, root user's prompt is #, non-root user's prompt's" >&2
+echo "warning: prompt is $, Please do not consider this a test failure" >&2
 
 ${THIS_SH} ./new-exp.tests 2>&1 | grep -v '^expect' > ${BASH_TSTOUT}
 diff ${BASH_TSTOUT} new-exp.right && rm -f ${BASH_TSTOUT}
-- 
2.7.4

Reply via email to