> Since it's a function, I would recommend return instead of exit.  Also,
> you don't need the $? there.  exit (or return) with no arguments will
> retain the exit status of the previous command.

Yes, $? is not needed.

exit or return is equivalent in this case though because of set -e.

> Putting "|| return" or "|| exit" after all critical commands in your
> script is precisely what you should do.  (Some people write a die()
> function and then use "|| die 'my message'" instead.)

I consider all commands critical, and if one is allowed to return
unsuccessful, I'd rather explicitly allow it with something like:

can_fail || :

I'm still curious as to why set -e is stripped in the first place?

Chris
-- 
echo mailto: NOSPAM !#$.'<*>'|sed 's. ..'|tr "<*> !#:2" org@fr33z3

Reply via email to