On Fri, 2007-12-21 at 13:51 +0100, Michael Haubenwallner wrote: > On Thu, 2007-12-20 at 08:08 -0500, Chet Ramey wrote: > > Michael Haubenwallner wrote: > > > Machine: i586 > > > OS: interix5.2 > > > Compiler: gcc > > > Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='i586' > > > -DCONF_OSTYPE='interix5.2' -DCONF_MACHTYPE='i586-pc-interix5.2' > > > -DCONF_VENDOR='pc' > > > -DLOCALEDIR='/tools/snapshot/prefix-launcher-1pre.20071219/i586-pc-interix5.2/share/locale' > > > -DPACKAGE='bash' > > > -DLOCAL_PREFIX=/tools/snapshot/prefix-launcher-1pre.20071219/i586-pc-interix5.2 > > > -DSHELL -DHAVE_CONFIG_H -DNO_MAIN_ENV_ARG -DBROKEN_DIRENT_D_INO > > > -D_POSIX_SOURCE -I. > > > -I/tss/prefix-launcher-1pre.20071219/buildroot/bash/bash-3.2 > > > -I/tss/prefix-launcher-1pre.20071219/buildroot/bash/bash-3.2/include > > > -I/tss/prefix-launcher-1pre.20071219/buildroot/bash/bash-3.2/lib -g -O2 > > > uname output: Interix pc312001 5.2 SP-9.0.3790.3034 x86 > > > Intel_x86_Family6_Model15_Stepping6 > > > Machine Type: i586-pc-interix5.2 > > > > > > Bash Version: 3.2 > > > Patch Level: 33 > > > Release Status: release > > > > > > Description: > > > Bash uses getcwd-replacement if libc provides getcwd without the > > > feature of allocating the buffer when called without one. > > > This override is done in config-bot.h, with an exception for > > > solaris already. > > > Problem now is that getcwd-replacement does not work on Interix > > > (SUA 5.2 here). > > > > I'd be more interested in knowing why it doesn't work in this case, > > instead of discarding it. Since I neither have nor use Interix, I > > need someone who does to investigate the issue a little bit. > > It is because readdir() returns 0 (zero) for (struct dirent).(d_ino), > while stat() returns useful values for (struct stat).(st_ino), so their > equal-comparison never succeeds.
Attached patch should fix this issue, not relying on readdir() returning valid d_ino, but doing stat() always instead. But eventually there should be a configure-check or sth. like that if readdir returns valid d_ino, and subsequently avoid the additional stat. Moving alloca() into separate function was necessary because there is no realloca() or sth. like that, and wasting stack for each iteration is bad. /haubi/ -- Michael Haubenwallner Gentoo on a different level
