On Fri, 2013-02-08 at 13:56 +0100, Pavel Raiskup wrote: > Hi Stefano, > > > >> [ ... ] > > > > > > Ping. Are you considering my opinions OK? > > > > > Basically yes; and a patch would obviously be welcome, if you want > > to speed up the fixing of this bug ;-) > > First proposal attached :) (0001-*).
I forgot to look at testsuite. Attaching additional patch to fix it.
>From fcfae8d37dea52ea201662ff9c756330be0d653b Mon Sep 17 00:00:00 2001 From: Pavel Raiskup <prais...@redhat.com> Date: Sat, 9 Feb 2013 07:52:09 +0100 Subject: [PATCH] tests: Command 'aclocal -Inon-existent' should warn Check that this command just warns and does not fail. See: <http://lists.gnu.org/archive/html/bug-automake/2013-01/msg00115.html> * t/aclocal-macrodir.tap: Check for proper return value and do not handle warnings as errors. --- t/aclocal-macrodir.tap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/aclocal-macrodir.tap b/t/aclocal-macrodir.tap index 3c66e53..f989640 100755 --- a/t/aclocal-macrodir.tap +++ b/t/aclocal-macrodir.tap @@ -157,14 +157,14 @@ test_end #--------------------------------------------------------------------------- -test_begin "AC_CONFIG_MACRO_DIR([non-existent]) errors out (1)" +test_begin "AC_CONFIG_MACRO_DIR([non-existent]) warns but succeeds (0)" cat > configure.ac << 'END' AC_INIT([oops], [1.0]) AC_CONFIG_MACRO_DIR([non-existent]) END -not $ACLOCAL -Wnone 2>stderr \ +$ACLOCAL -Wno-error 2>stderr \ && cat stderr >&2 \ && grep "couldn't open directory 'non-existent'" stderr \ || r='not ok' -- 1.7.11.7
