On 04/28/2012 11:25 AM, Marc-Antoine Perennou wrote: > The AM_SILENT_RULES macro needs an argument to be enabled. > Currently, if the silent-rules option is set in AM_INIT_AUTOMAKE, the > action is an AC_REQUIRE on the macro, which runs it without any arg, > resulting in an useless action. > The only way for now to enable silent-rules is to call > AM_SILENT_RULES([yes]), the silent-rules option has no effect at all. > This patch solves it, calling the macro with the right arg
NACK. This would change the default behavior. The 'silent-rules' listing in AM_INIT_AUTOMAKE is only to specify whether silent-rule support is turned on (and with a recent patch, this support is _always_ turned on now that we have a solution that works with POSIX make), and NOT whether it defaults to silent or verbose. AM_SILENT_RULES is the only documented way of changing the default between silent and verbose. > ]) > -_AM_IF_OPTION([silent-rules], [AC_REQUIRE([AM_SILENT_RULES])])dnl > +_AM_IF_OPTION([silent-rules], [AM_SILENT_RULES([yes]))dnl But this patch would change things so that the default is now verbose if you list silent-rules in AM_INIT_AUTOMAKE, which is not appropriate (at least, not without a NEWS entry and tests to validate the new behavior). -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
