On Sat, Mar 26, 2011 at 9:25 PM, Stephen Hemminger < [email protected]> wrote:
> On Sat, 26 Mar 2011 20:19:57 +0530 > Sasikanth V <[email protected]> wrote: > > > > > Signed-off-by: Sasikanth V <[email protected]> > > --- > > I will clean this up. There are things like introducing > global function names (set_forward_delay, etc) that need > to be fixed. > Thanks for looking at the patch. I made 5 set functions (set_forward_delay, set_max_age, set_hello_time, set_priority and set_ageing_time) in br_sysfs_br.c global to use in br_ioctl.c to avoid code duplication (but it looks it is not a good idea). Now i thought something like making those 5 functions static inline and moving it to br_private.h. If this is fine , I will resend the patch
_______________________________________________ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
