Thanks Sijie, I submitted the patch, plz let me know whether it's ok. Thanks, Jaln
On Mon, Jun 16, 2014 at 6:58 PM, Sijie Guo <[email protected]> wrote: > Ah, I just created bookkeeper-benchmark component. Could you try it again? > let me know if it works? > > > On Tue, Jun 10, 2014 at 3:18 PM, Jaln <[email protected]> wrote: > > > Hi, I want to create a patch to fix this typo. But there is no component > > matching the 'benchmark' > > "Component with id 'bookkeeper-benchmark' does not exist." > > > > Thanks, > > Jaln > > > > > > On Thu, Jun 5, 2014 at 9:28 PM, Jialin Gmail <[email protected]> > wrote: > > > > > Sounds good, I'll try. > > > > > > Best, > > > Jaln > > > > > > Sent from my iPhone > > > > > > > On Jun 5, 2014, at 9:20 PM, Sijie Guo <[email protected]> wrote: > > > > > > > > Yup. it should be 'milliseconds'. Do you want to create a patch to > fix > > > this? > > > > > > > > - Sijie > > > > > > > > > > > >> On Thu, Jun 5, 2014 at 5:49 PM, Jaln <[email protected]> wrote: > > > >> > > > >> Hi, > > > >> I tested the bookkeeper benchmark on one disk, > > > >> the result is > > > >> 290376 completions in 62000 seconds: 4683 ops/sec > > > >> 99th percentile latency: 1793.1247832959698 > > > >> 95th percentile latency: 1708.9804397097917 > > > >> > > > >> I think it should be 62000 milliseconds. > > > >> > > > >> Plz check the code in BenchThroughputLatency.java, > > > >> long tp = > > > >> (long)((double)(numcompletions*1000.0)/(double)bench.getDuration()); > > > >> > > > >> LOG.info(numcompletions + " completions in " + > > > bench.getDuration() > > > >> + " seconds: " + tp + " ops/sec"); > > > >> > > > >> getDuration() returns in milliseconds. > > > >> > > > >> > > > >> Plz let me know if I'm wrong. > > > >> > > > >> Best, > > > >> Jaln > > > >> > > > > > > > > > > > -- > > > > Genius only means hard-working all one's life > > > -- Genius only means hard-working all one's life
