[
https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009090#comment-14009090
]
Flavio Junqueira commented on BOOKKEEPER-760:
---------------------------------------------
If we really don't need this part of the code, I'd rather remove it altogether.
Some questions:
bq. // a. the dead bookies will be removed from topology, which will not be
used in new ensemble.
It depends on whether the session of the bookie has already expired, no?
bq. // b. the read sequence will be reordered based on znode availability, so
most of the reads will not be sent to them.
I'm not sure what reordered means here. Do you mean to say rerouted or resent?
{quote}
// c. the close here is just to disconnect the channel, which doesn't remove
the channel
// from from pcbc map. we don't really need to disconnect the channel here,
since if a bookie is
// really down, PCBC will disconnect itself based on netty callback. if we
try to disconnect
// here, it actually introduces side-effects on case d.
{quote}
Ok, this one sounds like a good reason for removing... but what are the
side-effects?
{quote}
// d. closing the client here will affect latency if the bookie is alive but
just being flaky
// on its znode registration due zookeeper session expire.
{quote}
I don't understand how it affects latency.
bq. // e. if we want to permanently remove a bookkeeper client, we should watch
on the cookies' list.
I'm a bit confused here. Do we even want to remove a bookkeeper client?
> Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
> --------------------------------------------------------------------------
>
> Key: BOOKKEEPER-760
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0, 4.2.3
>
> Attachments: BOOKKEEPER-760.diff
>
>
> Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
