[
https://issues.apache.org/jira/browse/BOOKKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997530#comment-13997530
]
Ivan Kelly commented on BOOKKEEPER-756:
---------------------------------------
Patch is nice.
2 minor things:
* timeouttimernumticks in config is unclear. it needs more descriptive name.
the documentation should be clear that this and the other tick related config
are hashwheeltimer internals, and that the user probably shouldnt touch them.
* Configuration#getReadEntryTimeout and Configuration#getAddEntryTimeOut called
once per request. It'd be better to just get the values when creating the pcbc
to avoid lock contention issues deep in Configuration.
> Use HashedwheelTimer for request timeouts for PCBC
> --------------------------------------------------
>
> Key: BOOKKEEPER-756
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-756
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0, 4.2.3
>
> Attachments: BOOKKEEPER-756.diff
>
>
> Current scheduler based timeout mechanism is per batch, which isn't
> efficient. HashedWheelTimer is much better for timeouts. So change the PCBC
> to use HashedWheelTimer for timeouts.
> Besides that HashedWheelTimer change, it also provides multiple channel per
> bookie support for latency consideration.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
