[
https://issues.apache.org/jira/browse/BOOKKEEPER-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917790#comment-13917790
]
Sijie Guo commented on BOOKKEEPER-629:
--------------------------------------
the patch looks good. but after thinking a bit more, the try catch logic to
search both ip and hostname znodes is not good enough for extending in future,
if we want to support other id for bookie id in future. so I am kind of
thinking we should do as below:
- if there is any cookie files in the local directory, we should use bookieHost
in the cookie file as bookie id (znode path) to check, regarding the settings
in configuration.
- if there is no cookie files in local directory, we use the settings in the
configuration to decide whether using ip or address as bookie id.
> Support hostname based ledger metadata to help users to change IP with
> existing installation
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-629
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-629
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery, bookkeeper-client,
> bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Vinayakumar B
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 1-BOOKKEEPER-629.patch, 10-BOOKKEEPER-629.patch,
> 2-BOOKKEEPER-629.patch, 3-BOOKKEEPER-629.patch, 4-BOOKKEEPER-629.patch,
> 5-BOOKKEEPER-629.patch, 6-BOOKKEEPER-629.patch, 7-BOOKKEEPER-629.patch,
> 9-BOOKKEEPER-629.patch
>
>
> Register the bookie with *hostname:port* and also store the bookie addresses
> as *hostname:port* in ledger metadata files instead of *ip:port*
> This will help users to change the machine IP if they want without loosing
> their data.
> Supporting hostname based installation/functionality is one of the important
> requirement of users.
> Any thoughts?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
