[
https://issues.apache.org/jira/browse/BOOKKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890972#comment-13890972
]
Hadoop QA commented on BOOKKEEPER-729:
--------------------------------------
Testing JIRA BOOKKEEPER-729
Patch
[0005-BOOKKEEPER-729-When-bookie-exits-with-an-error-and-c.patch|https://issues.apache.org/jira/secure/attachment/12626904/0005-BOOKKEEPER-729-When-bookie-exits-with-an-error-and-c.patch]
downloaded at Tue Feb 4 17:57:59 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:red}-1 RAT{color}
. {color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 893
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/579/
> Bookie shouldn't exit with 0, if exiting from deathwatcher and thread death
> was caused by OOM
> ---------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-729
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-729
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0005-BOOKKEEPER-729-When-bookie-exits-with-an-error-and-c.patch
>
>
> I've seen the deathwatcher reset the exit code to 0, even after it was set
> correct. We should make setting the exitcode a one way operation.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
