[
https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881264#comment-13881264
]
Sijie Guo commented on BOOKKEEPER-708:
--------------------------------------
-1 for shading netty, since ClientSocketChannelFactory is used as constructor
for BookKeeper. If we shade netty, we can't share same
ClientSocketChannelFactory with bookkeeper client.
as I said before, don't shade libraries that used in public method. and if you
want to shade netty, please clarify what's the issue before shading.
> Shade protobuf library to avoid incompatible versions
> -----------------------------------------------------
>
> Key: BOOKKEEPER-708
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Rakesh R
> Fix For: 4.3.0, 4.2.3
>
> Attachments:
> 0001-BOOKKEEPER-708-Shade-libraries-to-avoid-incompatible.patch,
> 0001-BOOKKEEPER-708-Shade-protobuf-library-to-avoid-incom.patch,
> 0001-BOOKKEEPER-708.patch, 0002-BOOKKEEPER-708.patch
>
>
> as offline discussion, we need to shade protobuf library for BKJM as hadoop
> uses protobuf 2.5.
> this is planned on version 4.2.3 and 4.3.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
