[
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881068#comment-13881068
]
Flavio Junqueira commented on BOOKKEEPER-654:
---------------------------------------------
the patch looks good overal. there are two main things I can spot here:
# creating a ClientClosedException so that we can error out operations once the
client is closed
# adding CleanupLedgerManager to reject new metadata operations once the client
is closed
other than that, there a number of smaller changes to make it work. I was
wondering if you'd mind posting the patch to the review board so that I could
make specific comments more easily. so far I haven't spotted any major issue.
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-654
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.2.0
> Reporter: Rakesh R
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-654-Bookkeeper-client-operations-are-allo.patch,
> 0001-BOOKKEEPER-654-testcase-to-understand-more.patch,
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch,
> 0004-BOOKKEEPER-654.patch, 0005-BOOKKEEPER-654.patch,
> 0006-BOOKKEEPER-654-handled-inprogress-and-newrequests.patch,
> BOOKKEEPER-654.diff, BOOKKEEPER-654.diff, BOOKKEEPER-654.diff
>
>
> User can perform below operations with the closed bookkeeper client, which
> was instantiated with external zkclient.
> - open a closed ledger
> - create a new ledger
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
