[
https://issues.apache.org/jira/browse/BOOKKEEPER-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841072#comment-13841072
]
Hadoop QA commented on BOOKKEEPER-713:
--------------------------------------
Testing JIRA BOOKKEEPER-713
Patch
[BOOKKEEPER-713.patch|https://issues.apache.org/jira/secure/attachment/12617347/BOOKKEEPER-713.patch]
downloaded at Fri Dec 6 07:22:24 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 885
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/547/
> Bookie should store the cookie in zookeeper first
> -------------------------------------------------
>
> Key: BOOKKEEPER-713
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-713
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.2.2
> Reporter: Vinay
> Assignee: Vinay
> Attachments: BOOKKEEPER-713.patch
>
>
> following code in {{Bookie#checkEnvironment(..)}} should store the cookie in
> zookeeper and then to local disks for {{newEnv}}
> {code} if (newEnv) {
> if (missedCookieDirs.size() > 0) {
> LOG.debug("Directories missing cookie file are {}",
> missedCookieDirs);
> masterCookie.writeToDirectory(journalDirectory);
> for (File dir : allLedgerDirs) {
> masterCookie.writeToDirectory(dir);
> }
> }
> masterCookie.writeToZooKeeper(zk, conf);
> }{code}
> Otherwise if the {{masterCookie.writeToZooKeeper(zk, conf);}} fails due to
> some exception, then bookie cannot start again.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
