[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720972#comment-13720972
 ] 

Ivan Kelly commented on BOOKKEEPER-596:
---------------------------------------

Patch looks like it solves it. I think it should go into a new JIRA though. 
BOOKKEEPER-596 already has a patch, albeit a faulty one. It's much to late to 
roll it back, so we need a new patch (mark for 4.3.0 and 4.2.2).

In the patch, Collections2 is unused. Also, it would be better for the test to 
cross 2 ranges at least, so set numLedgers to 30001 or so.
                
> Ledgers are gc'ed by mistake in MSLedgerManagerFactory.
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-596
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-596
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.0, 4.2.1
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: 
> 0001-BOOKKEEPER-596-Ledgers-are-gc-ed-by-mistake-in-MSLed.patch, 
> 0001-BOOKKEEPER-596-Ledgers-are-gc-ed-by-mistake-in-MSLed.patch, 
> BOOKKEEPER-596.diff, BOOKKEEPER-596.patch, BOOKKEEPER-596.patch, 
> BOOKKEEPER-596.patch
>
>
> details: 
> https://issues.apache.org/jira/browse/BOOKKEEPER-590?focusedCommentId=13616397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13616397

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to