[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718433#comment-13718433
 ] 

Ivan Kelly commented on BOOKKEEPER-632:
---------------------------------------

InetSocketAddress can easily be converted to String with 
o.a.bookkeeper.util.StringUtils#addrToString. Reading directly from ZK is bad, 
because it's putting duplicate code in a number of places, which need to be 
updated if there's a change to the /ledgers/available format. For example, when 
/ledgers/available/readonly was added, this broke some bits of code that 
expected every znode under /ledgers/available to be a bookie. In fact, the code 
that this is fixing was guilty of this. Moving the handling of ZK to a central 
place prevents this situation occurring again in the future.
                
> AutoRecovery should consider read only bookies
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-632
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-auto-recovery, bookkeeper-server
>    Affects Versions: 4.2.1, 4.3.0
>            Reporter: Vinay
>            Assignee: Vinay
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, 
> BOOKKEEPER-632.patch
>
>
> Autorecovery Auditor should consider the readonly bookies as Available 
> Bookies  while publishing the under-replicated ledgers.
> Also AutoRecoveryDaemon should shutdown if the local bookie is readonly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to