[
https://issues.apache.org/jira/browse/BOOKKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713850#comment-13713850
]
Ivan Kelly commented on BOOKKEEPER-602:
---------------------------------------
The patch looks mostly good. Setting the getAddEntryTimeout() to 1 is too low
though, and a behavioural break. It should default to the value of
getReadTimeout(), which should also be deprecated. The fact that you had to
create a TestBKConfiguration shows that it breaks current behaviour. Also, the
test failure needs to be fixed.
> we should have request timeouts rather than channel timeout in
> PerChannelBookieClient
> -------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-602
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-602
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.2.0, 4.2.1
> Reporter: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-602.diff
>
>
> currently we only have readTimeout in netty channel, it timeouts only when
> there is no activities in that channel, but it can't track timeouts of
> individual requests. if a channel continues having read entry activities, it
> might shadow a slow add entry response, which is bad impacting add latency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
