The file_upload_handler supports partial uploads. Is it safe to assume that the file is really complete after copy_socket_to_file() is successful or is it possible that it was only a first chunk of data and the client may send more in a second request? Which will fail right now because the file is read only after the first request.
Regards Christian On 10/17/2015 07:59 AM, David Anderson wrote: > Christian: > I checked in a change that should do this. > Please review and test if you get a chance. > -- David > > On 10/16/2015 2:24 AM, Christian Beer wrote: >> Hi David, >> >> we want to make a change to the file_upload_handler that will set the >> completely uploaded result file read_only. I checked the code but >> couldn't find the right place to put the change in. I think line 414 in >> file_upload_handler.cpp would be the place but I'm not sure if the file >> is really complete at this point. >> >> We would add a detection for this read_only case and print a log message >> in order to get to know how much this happens and with what client >> versions. >> >> The background is that sometimes the client re-uploads already validated >> and assimilated result files which we want to prohibit. >> >> Regards >> Christian > _______________________________________________ boinc_dev mailing list [email protected] http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
