Sorry David, I unfortunately cannot test it because I don't have any solaris platform here, but the commit seems to be rather good to me, in the next upload I'll see if one of the many different debian plaforms complains and report back here
(BTW the kfreebsd-* fail to build from source has been successfully fixed, thanks!) cheers, Gianfranco > Il Venerdì 21 Marzo 2014 3:44, David Anderson <[email protected]> ha > scritto: > > I changed this; please see if it works. > -- David > > > On 21-Feb-2014 1:26 AM, Gianfranco Costamagna wrote: >> Hi David, >> >> Little note: >> >> #ifdef HAVE_STRUCT_LIFCONF >> struct lifreq *item = &ifr[i]; >> #else >> struct ifreq *item = &ifr[i]; >> #endif >> >> >> in case of struct lifreq the member name is item->lifrn_name, >> reference [1] >> >> >> [1] > https://community.cablelabs.com/svn/OCAPRI/tags/stable_ctp_no_upnp/ri/ODLSrc/OCAP-1.0/jvm/Sun/src/mpe/native/java/net/ipv6_defs.h >> I'm not sure, but this can introduce a ftbfs on solaris platforms (but > I don't have any solaris here for testing) >> >> bests, >> >> >> Gianfranco >> >> >> >> >>> Il Venerdì 21 Febbraio 2014 10:19, Gianfranco Costamagna > <[email protected]> ha scritto: >>>> T hanks a ton, I'll add this patch and rebuild! >>> >>> Cheers, >>> >>> >>> Gianfranco >>> >>> >>> >>> >>> >>>> Il Giovedì 20 Febbraio 2014 19:12, David Anderson >>> <[email protected]> ha scritto: >>>> > I checked in a possible fix. >>>> In general, issues like this need to be fixed via autoconf, >>>> not by adding #ifdefs. >>>> -- David >>>> >>>> >>>> On 20-Feb-2014 2:49 AM, Gianfranco Costamagna wrote: >>>>> Hi David and all, >>>>> >>>>> did you have any clue for this problem? >>>>> >>>>> ^ >>>>> mv -f .deps/boinc_client-hostinfo_unix.Tpo >>>> .deps/boinc_client-hostinfo_unix.Po >>>>> g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../api -I../db -I../lib >>> -I../lib/mac >>>> -I../sched -I../tools -I../vda -pthread -D_FORTIFY_SOURCE=2 > -Wall -Wextra >>>> -Wshadow -Wredundant-decls -Wdisabled-optimization > -Wpointer-arith >>>> -Wstrict-aliasing -Wcast-align -I/usr/include > -I/usr/include/openssl -g >>> -O2 >>>> -fstack-protector --param=ssp-buffer-size=4 -Wformat >>> -Werror=format-security >>>> -Wall -O3 -funroll-loops -fforce-addr -ffast-math -Wall -MT >>>> boinc_client-http_curl.o -MD -MP -MF > .deps/boinc_client-http_curl.Tpo -c -o >>> >>>> boinc_client-http_curl.o `test -f 'http_curl.cpp' || echo >>>> './'`http_curl.cpp >>>>> mv -f .deps/boinc_client-http_curl.Tpo > .deps/boinc_client-http_curl.Po >>>>> g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../api -I../db -I../lib >>> -I../lib/mac >>>> -I../sched -I../tools -I../vda -pthread -D_FORTIFY_SOURCE=2 > -Wall -Wextra >>>> -Wshadow -Wredundant-decls -Wdisabled-optimization > -Wpointer-arith >>>> -Wstrict-aliasing -Wcast-align -I/usr/include > -I/usr/include/openssl -g >>> -O2 >>>> -fstack-protector --param=ssp-buffer-size=4 -Wformat >>> -Werror=format-security >>>> -Wall -O3 -funroll-loops -fforce-addr -ffast-math -Wall -MT >>>> boinc_client-log_flags.o -MD -MP -MF > .deps/boinc_client-log_flags.Tpo -c -o >>> >>>> boinc_client-log_flags.o `test -f 'log_flags.cpp' || echo >>>> './'`log_flags.cpp >>>>> mv -f .deps/boinc_client-log_flags.Tpo > .deps/boinc_client-log_flags.Po >>>>> g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../api -I../db -I../lib >>> -I../lib/mac >>>> -I../sched -I../tools -I../vda -pthread -D_FORTIFY_SOURCE=2 > -Wall -Wextra >>>> -Wshadow -Wredundant-decls -Wdisabled-optimization > -Wpointer-arith >>>> -Wstrict-aliasing -Wcast-align -I/usr/include > -I/usr/include/openssl -g >>> -O2 >>>> -fstack-protector --param=ssp-buffer-size=4 -Wformat >>> -Werror=format-security >>>> -Wall -O3 -funroll-loops -fforce-addr -ffast-math -Wall -MT >>>> boinc_client-mac_address.o -MD -MP -MF > .deps/boinc_client-mac_address.Tpo >>> -c -o >>>> boinc_client-mac_address.o `test -f 'mac_address.cpp' || > echo >>>> './'`mac_address.cpp >>>>> mac_address.cpp: In function 'int > get_mac_address(char*)': >>>>> mac_address.cpp:267:26: error: 'struct ifreq' has no > member >>> named >>>> 'ifr_ifrn' if (strstr(item->ifr_ifrn.ifrn_name, >>> "eth")) >>>> break; ^ >>>>> >>>>> >>>>> it should be fairly trivial to solve, maybe adding an ifdef > linux or >>>> something similar to exclude this fail on kfreebsd-* platforms. >>>>> >>>>> >>>>> >>>>> what do you think about? I can patch it on debian, but I > really like >>> to >>>> have a feedback from you, >>>>> >>>>> thanks, >>>>> >>>>> >>>>> Gianfranco >>>>> >>>>> >>>>> >>>>> >>>>> Il Mercoledì 19 Febbraio 2014 18:05, Gianfranco Costamagna >>>> <[email protected]> ha scritto: >>>>> >>>>> Hi boinc developers, >>>>>> the new get_mac_address doesn't work on freebsd >>>>>> >>>>>> this is an example of build log >>>>>> >>>> >>> > https://buildd.debian.org/status/fetch.php?pkg=boinc&arch=kfreebsd-amd64&ver=7.2.39%2Bdfsg-1&stamp=1392814949 >>>>>> >>>>>> Should we just exclude it? >>>>>> >>>>>> thanks, >>>>>> >>>>>> Gianfranco >>>>>> >>>>>> >>>>>> >>>> >>> > _______________________________________________ boinc_dev mailing list [email protected] http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
