LGTM2 On 11/8/23 11:58 AM, Yoav Weiss wrote:
LGTM1On Monday, November 6, 2023 at 9:21:34 PM UTC+1 Vladimir Levin wrote: Contact emails [email protected] Explainer None Specification https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility <https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility> Summary This feature adds three more values to the checkVisibility (https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility <https://drafts.csswg.org/cssom-view/#dom-element-checkvisibility>) dictionary members: * opacityProperty as an alias for checkOpacity * visibilityProperty as an alias for checkVisibilityCSS * contentVisibilityAuto as a property that allows checking whether an element is in a subtree skipped by content-visibility: auto. See https://github.com/w3c/csswg-drafts/pull/9549 <https://github.com/w3c/csswg-drafts/pull/9549> Blink component Blink>DOM <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> TAG review None TAG review status Not applicable, it's a small addition to an existing feature Risks Interoperability and Compatibility None /Gecko/: No signal (https://github.com/mozilla/standards-positions/issues/920 <https://github.com/mozilla/standards-positions/issues/920>) /WebKit/: Positive (https://github.com/w3c/csswg-drafts/issues/9487#issuecomment-1782109845 <https://github.com/w3c/csswg-drafts/issues/9487#issuecomment-1782109845>) The naming proposal came from Safari /Web developers/: No signals /Other signals/: Ergonomics There are no ergonomic risks, since this adds extra properties to an existing feature. Activation There are no activation risks, since this adds extra (useful) properties to an existing feature Security There are no extra security issues here that were not already considered during the checkVisibility review. WebView application risks Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? None Debuggability This would be debugged as any other script APIs Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? Yes Will write tests as a part of the implementation Flag name on chrome://flags Finch feature name CheckVisibilityExtraProperties Requires code in //chrome? False Estimated milestones Shipping on desktop 121 DevTrial on desktop 121 Shipping on Android 121 DevTrial on Android 121 Shipping on WebView 121 Anticipated spec changes Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). https://github.com/w3c/csswg-drafts/pull/9549 <https://github.com/w3c/csswg-drafts/pull/9549> Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5070043440480256 <https://chromestatus.com/feature/5070043440480256> Links to previous Intent discussions Intent to prototype: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2NjBPfNAftFFjSKxyX0PXtWpuK%2BQ1QrUaAQrjV9EfouOQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2NjBPfNAftFFjSKxyX0PXtWpuK%2BQ1QrUaAQrjV9EfouOQ%40mail.gmail.com> This intent message was generated by Chrome Platform Status <https://chromestatus.com/>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/21f32a6c-ea3c-4923-925a-3067831ca645n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/21f32a6c-ea3c-4923-925a-3067831ca645n%40chromium.org?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/bb09bc42-abdc-4f6b-9b48-c5a7b9913f03%40chromium.org.
