Thanks! I will aim to ship in M110. On Thursday, 10 November 2022 at 5:32:14 pm UTC+11 Yoav Weiss wrote:
> LGTM3 > > On Wed, Nov 9, 2022, 17:37 Mike Taylor <[email protected]> wrote: > >> LGTM2 >> >> On 11/10/22 1:36 AM, Chris Harrelson wrote: >> >> Thanks! >> LGTM1 >> >> On Tue, Nov 8, 2022 at 6:57 PM Alan Cutter <[email protected]> >> wrote: >> >>> https://github.com/WICG/web-app-launch/issues/69 and >>> https://github.com/WICG/web-app-launch/issues/67 spec issues have now >>> been fixed. >>> >>> On Wednesday, 2 November 2022 at 5:39:57 pm UTC+11 Alan Cutter wrote: >>> >>>> On Sunday, 30 October 2022 at 3:13:03 am UTC+11 Yoav Weiss wrote: >>>> >>>>> On Sat, Oct 29, 2022 at 6:08 PM Yoav Weiss <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, Oct 28, 2022 at 5:01 AM Alan Cutter <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Friday, 21 October 2022 at 5:20:23 pm UTC+11 Alan Cutter wrote: >>>>>>> >>>>>>>> On Wednesday, 19 October 2022 at 11:52:32 pm UTC+11 Yoav Weiss >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hey! Thanks for pushing this :) >>>>>>>>> >>>>>>>>> On Tue, Oct 18, 2022 at 8:42 AM Alan Cutter < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Contact emails [email protected], [email protected] >>>>>>>>>> >>>>>>>>>> Explainer >>>>>>>>>> https://github.com/WICG/sw-launch/blob/main/launch_handler.md >>>>>>>>>> >>>>>>>>>> Specification https://wicg.github.io/sw-launch >>>>>>>>>> >>>>>>>>> >>>>>>>>> I went over the spec and filed a few issues. None of them seems >>>>>>>>> blocking (as in, they won't change the API shape), but they'd help us >>>>>>>>> achieve an interoperable specification. >>>>>>>>> >>>>>>>> Thanks! There is definitely hand waviness in this spec, this is >>>>>>>> deliberate as it's describing the "end" of the launch pipeline where >>>>>>>> the >>>>>>>> launch "start" or "trigger" is decided by other specs/the user agent. >>>>>>>> I >>>>>>>> need to figure out how to word such open behaviours in specese. >>>>>>>> >>>>>>>> >>>>>>>>> Would it be possible for y'all to go over the issues list, close >>>>>>>>> the ones that are no longer relevant, and then label ones that may >>>>>>>>> contain >>>>>>>>> any future compat risk, if any? (That is, issues that may change the >>>>>>>>> API >>>>>>>>> shape once resolved) >>>>>>>>> >>>>>>>> Closed a few: >>>>>>>> https://github.com/WICG/sw-launch/issues?q=is%3Aissue+is%3Aclosed+updated%3A%3E%3D2022-10-20+ >>>>>>>> Marked most of the existing issues as future-api work (extensions >>>>>>>> to the current API). >>>>>>>> Marked one as a potential compat risk: >>>>>>>> https://github.com/WICG/sw-launch/issues/48 >>>>>>>> >>>>>>> >>>>> Seems like the issue converges on leaving the existing behavior as >>>>> is. Does that mean the risk is lowered here? >>>>> >>>> Yes, I consider any changes there to be future API extensions and the >>>> current behavior is fine as is. >>>> >>>> >>>>> Also, I think it'd be good to address >>>>> https://github.com/WICG/web-app-launch/issues/67 (and define the >>>>> callers to the algorithm) before shipping. >>>>> >>>> This is underway, 3 PRs are in review: >>>> - https://github.com/w3c/manifest/pull/1056 >>>> - https://github.com/WICG/web-app-launch/pull/79 >>>> - https://github.com/WICG/manifest-incubations/pull/63 >>>> >>>> >>>>> >>>>> >>>>>>>>> Aside: should the repo be renamed to "web-app-launch" or something >>>>>>>>> similar? >>>>>>>>> >>>>>>>> If old links can continue to work SGTM. >>>>>>>> >>>>>>> The rename has been done. The old GitHub links will redirect but the >>>>>>> old spec link no longer works. >>>>>>> The draft spec is now at: https://wicg.github.io/web-app-launch/ >>>>>>> >>>>>> >>>>>> Added a redirect from the old link to the new one. >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Summary >>>>>>>>>> >>>>>>>>>> Add a "launch_handler" web app manifest member that enables web >>>>>>>>>> apps to customize their launch behavior across all types of app >>>>>>>>>> launch >>>>>>>>>> triggers. Example usage: { "name": "Example app", "start_url": >>>>>>>>>> "/index.html", "launch_handler": { "client_mode": >>>>>>>>>> "navigate-existing" } } >>>>>>>>>> This will cause all launches of the Example app to focus an existing >>>>>>>>>> app >>>>>>>>>> window and navigate it (if it exists) instead of always opening a >>>>>>>>>> new app >>>>>>>>>> window. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Blink component Blink>AppManifest >>>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EAppManifest> >>>>>>>>>> >>>>>>>>>> Search tags web app >>>>>>>>>> <https://chromestatus.com/features#tags:web%20app>, pwa >>>>>>>>>> <https://chromestatus.com/features#tags:pwa>, link capturing >>>>>>>>>> <https://chromestatus.com/features#tags:link%20capturing>, link >>>>>>>>>> handling <https://chromestatus.com/features#tags:link%20handling> >>>>>>>>>> , launch <https://chromestatus.com/features#tags:launch> >>>>>>>>>> >>>>>>>>>> TAG review https://github.com/w3ctag/design-reviews/issues/683 >>>>>>>>>> >>>>>>>>>> TAG review status Issues addressed >>>>>>>>>> >>>>>>>>>> Link to origin trial feedback summary >>>>>>>>>> https://docs.google.com/document/d/1t60YeQ-d-FSr9i91jvylW6sA7_R4jDnX1G4_PDfssYE/edit >>>>>>>>>> >>>>>>>>>> Risks >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Interoperability and Compatibility >>>>>>>>>> >>>>>>>>>> *Gecko*: No signal ( >>>>>>>>>> https://github.com/mozilla/standards-positions/issues/567) >>>>>>>>>> >>>>>>>>>> *WebKit*: No signal ( >>>>>>>>>> https://lists.webkit.org/pipermail/webkit-dev/2022-May/032243.html >>>>>>>>>> ) >>>>>>>>>> >>>>>>>>>> *Web developers*: Strongly positive. Feedback from sites using >>>>>>>>>> this API has been strongly in favor of keeping the functionality. >>>>>>>>>> >>>>>>>>>> *Other signals*: >>>>>>>>>> >>>>>>>>>> WebView application risks >>>>>>>>>> >>>>>>>>>> Does this intent deprecate or change behavior of existing APIs, >>>>>>>>>> such that it has potentially high risk for Android WebView-based >>>>>>>>>> applications? >>>>>>>>>> >>>>>>>>>> None. This feature only affects installed web apps which run in a >>>>>>>>>> regular browser environment rather than a WebView. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Debuggability >>>>>>>>>> >>>>>>>>>> Adding the field to DevTools is in progress >>>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/detail?id=1375962>. >>>>>>>>>> >>>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? No, >>>>>>>>>> desktop only. >>>>>>>>>> >>>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>>> ? No, this requires browser_tests >>>>>>>>>> <https://source.chromium.org/search?q=class:WebAppLaunchHanderBrowserTest&ss=chromium> >>>>>>>>>> as >>>>>>>>>> it involves managing windows. >>>>>>>>>> Have raised an issue >>>>>>>>>> <https://github.com/web-platform-tests/wpt/issues/33835> with >>>>>>>>>> testdriver.js for web app specific support. >>>>>>>>>> >>>>>>>>>> Flag name chrome://flags/#enable-desktop-pwas-launch-handler >>>>>>>>>> kWebAppEnableLaunchHandler >>>>>>>>>> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/common/features.h;bpv=1;bpt=1;l=376?q=kWebAppEnableLaunchHandler&gsn=kWebAppEnableLaunchHandler&gs=kythe%3A%2F%2Fchromium.googlesource.com%2Fchromium%2Fsrc%3Flang%3Dc%252B%252B%3Fpath%3Dthird_party%2Fblink%2Fpublic%2Fcommon%2Ffeatures.h%23dBeGhIBrlUn9xqyup36XrW7qdqyxtZdxlPtCpwHSK7k> >>>>>>>>>> >>>>>>>>>> Requires code in //chrome? True >>>>>>>>>> >>>>>>>>>> Tracking bug >>>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1231886 >>>>>>>>>> >>>>>>>>>> Launch bug https://launch.corp.google.com/launch/4207744 >>>>>>>>>> >>>>>>>>>> Non-OSS dependencies >>>>>>>>>> >>>>>>>>>> Does the feature depend on any code or APIs outside the Chromium >>>>>>>>>> open source repository and its open-source dependencies to function? >>>>>>>>>> None. >>>>>>>>>> >>>>>>>>>> Estimated milestones >>>>>>>>>> OriginTrial desktop last 110 >>>>>>>>>> OriginTrial desktop first 98 >>>>>>>>>> >>>>>>>>>> Anticipated spec changes >>>>>>>>>> >>>>>>>>>> Open questions about a feature may be a source of future web >>>>>>>>>> compat or interop issues. Please list open issues (e.g. links to >>>>>>>>>> known >>>>>>>>>> github issues in the project for the feature specification) whose >>>>>>>>>> resolution may introduce web compat/interop risk (e.g., changing to >>>>>>>>>> naming >>>>>>>>>> or structure of the API in a non-backward-compatible way). >>>>>>>>>> >>>>>>>>>> Currently launch_handler interacts poorly with share_target and >>>>>>>>>> may drop in-transit user data. This will be fixed with follow up >>>>>>>>>> spec >>>>>>>>>> additions to LaunchParams: >>>>>>>>>> https://github.com/WICG/sw-launch/issues/62 >>>>>>>>>> For the initial launch launch_handler will be ignored for >>>>>>>>>> share_target launches. >>>>>>>>>> >>>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>>> https://chromestatus.com/feature/5722383233056768 >>>>>>>>>> >>>>>>>>>> Links to previous Intent discussions Intent to prototype: >>>>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/8tNe2jrJ78A >>>>>>>>>> Intent to Experiment: >>>>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/wNOClobsLrs >>>>>>>>>> Request to Extend Experiment (rejected): >>>>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/pKl0eEeN5U4 >>>>>>>>>> Intent to Extend Experiment: >>>>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/BzwopwOFzFw >>>>>>>>>> Intent to Extend Experiment 2: >>>>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/3jO8Ij2UZoI >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>>> <https://chromestatus.com/>. >>>>>>>>>> >>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>> send an email to [email protected]. >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CANJJ2Cm9TG4E2ovLYZQR23pDA7AE%2BuYNpk6du-dZV4p2vgfvPg%40mail.gmail.com >>>>>>>>>> >>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CANJJ2Cm9TG4E2ovLYZQR23pDA7AE%2BuYNpk6du-dZV4p2vgfvPg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>> . >>>>>>>>>> >>>>>>>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4b8b2f31-207d-427d-9569-066c408322e2n%40chromium.org >>> >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4b8b2f31-207d-427d-9569-066c408322e2n%40chromium.org?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9mz%3DWMOxFTLVGa4rsQRQsjK%2BRK81vjiLTfsi%3DhYOcJ8Q%40mail.gmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9mz%3DWMOxFTLVGa4rsQRQsjK%2BRK81vjiLTfsi%3DhYOcJ8Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6dd30049-7274-4114-aa84-e98074e92134n%40chromium.org.
