LGTM2 On Wed, Sep 28, 2022 at 8:36 AM Philip Jägenstedt <[email protected]> wrote:
> LGTM1 > > The spec PR was merged and it's live here: > https://wicg.github.io/urlpattern/#options-ignore-case > > On Wed, Sep 28, 2022 at 5:08 PM Ben Kelly <[email protected]> wrote: > >> Contact [email protected] >> >> Explainer >> https://github.com/WICG/urlpattern/issues/148#issuecomment-965193134 >> >> Specificationhttps://github.com/WICG/urlpattern/pull/168 >> >> Summary >> >> Many client-side JavaScript frameworks currently use case insensitive URL >> matching. URLPattern, however, follows URL semantics and treats many parts >> of the URL as case sensitive. This feature adds an `ignoreCase` option to >> the URLPattern that switches all matching operations to case insensitive >> for that given pattern. >> >> >> Blink componentBlink>URLPattern >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EURLPattern> >> >> TAG reviewThis is a very small addition to an existing API. I added a >> comment to the previous TAG review, but did not open a new TAG review for >> it. See: >> https://github.com/w3ctag/design-reviews/issues/417#issuecomment-1261039149 >> >> TAG review statusNot applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> The addition of the options dictionary argument is backward compatible. >> There should not be any web compat risk. No other browser has implemented >> URLPattern yet, so there is no interop risk. The polyfill has an open pull >> request to add the feature to it as well. >> >> *Gecko*: No signal ( >> https://github.com/mozilla/standards-positions/issues/566#issuecomment-1261037497 >> ) >> >> *WebKit*: No signal ( >> https://github.com/WebKit/standards-positions/issues/61#issuecomment-1261037755 >> ) >> >> (Note, since this is a small addition to an existing API I posted >> comments on the existing position issues for the overall URLPattern API.) >> >> *Web developers*: Positive ( >> https://github.com/WICG/urlpattern/issues/148#issue-1049642081) This was >> a web developer community request and the spec/polyfill changes were >> contributed by an external web developer. >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> This is a small addition that is wholly contained within blink. It should >> not pose any webview risk. >> >> >> Debuggability >> >> This is a small change to an existing API and does not require any >> devtools enhancements. >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)?Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?Yes >> >> Flag name >> >> Requires code in //chrome?False >> >> Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=1345036 >> >> Estimated milestones >> DevTrial on desktop 107 >> DevTrial on Android 107 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> The spec changes have already landed. See: >> https://github.com/WICG/urlpattern/pull/168 >> https://github.com/WICG/urlpattern/pull/169 >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5206436850696192 >> >> Links to previous Intent discussionsIntent to prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK7rkMiXMaBM6%2Bi_g4suZK6Vvf_-SmAhRmkuNBji7eWPtV5bnw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cak7rkmixmabm6+i_g4suzk6vvf_-smahrmkunbji7ewptv5...@mail.gmail.com> >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK7rkMgT9GY%2B0DCwnSOXAQuMmCWK3rfhLF8zSFiENkNSSkajnw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK7rkMgT9GY%2B0DCwnSOXAQuMmCWK3rfhLF8zSFiENkNSSkajnw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdy6xRMoLF5V9y%2B4C_m-yG9Z6u--ytM1LjaWYx%3Dk_QF3A%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdy6xRMoLF5V9y%2B4C_m-yG9Z6u--ytM1LjaWYx%3Dk_QF3A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9vNsmQyzH6DxgQHAtTWzin3CC-dUabEMaNbSu2pgWSFQ%40mail.gmail.com.
