On Thu, Sep 22, 2022 at 5:34 AM Mike Taylor <[email protected]> wrote:
> LGTM2 > > On 9/22/22 12:04 AM, Yoav Weiss wrote: > > LGTM1 > > On Wed, Sep 21, 2022 at 9:10 PM 'Daseul Lee' via blink-dev < > [email protected]> wrote: > >> >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? >> >> No >> >> Web Platform Tests are not available on Android. >> >> (The answer should probably be yes here, I think.) > > Out of curiosity, do we have (manual?) tests that cover the DnD > functionality that this intent does not support, for Desktop? I see there > are some showPicker tests. > There are browser tests for the DnD functionality. Chrome's web platform test infrastructure bypasses so much of chrome's drag&drop implementation that even if we would/could write a WPT that would try to exercise the DnD code (there are some for other file DnD features) we're not really testing the real implementation anymore. > > https://wpt.fyi/results/file-system-access?label=master&label=experimental&aligned&view=subtest > > thanks, > Mike > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8ee76bfb-45b8-f0bf-a3bf-82d9ea0d78c5%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8ee76bfb-45b8-f0bf-a3bf-82d9ea0d78c5%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2BOSsVah_280Y-0Zr_6NC_04t309taeW5e3qgnxJcuYCnWTmtQ%40mail.gmail.com.
