LGTM2, also assuming you handle Mozilla's concerns reasonably. I'm happy to see y'all have thought through the CORS implications, and requiring `cors` or `same-origin` requests alleviates my minor concerns about leaking a server's support for HTTP/1 vs HTTP/2+.
-mike On Wed, Jul 13, 2022 at 1:16 PM Yoav Weiss <[email protected]> wrote: > LGTM1 > > This seems like a useful addition, web developer signals look great, and > it's great to have Mozilla on board with this. Please make sure to answer > their questions on the position issue. > > On Wed, Jul 13, 2022 at 12:27 PM Yutaka Hirano <[email protected]> > wrote: > >> >> >> On Wed, Jul 13, 2022 at 7:23 PM Yoav Weiss <[email protected]> >> wrote: >> >>> >>> >>> On Monday, July 11, 2022 at 12:50:11 PM UTC+2 Yutaka Hirano wrote: >>> >>>> On Mon, Jul 11, 2022 at 7:41 PM Yutaka Hirano <[email protected]> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Mon, Jul 11, 2022 at 5:41 PM Yoav Weiss <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Jul 11, 2022 at 10:17 AM Yutaka Hirano <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Contact [email protected] >>>>>>> >>>>>>> Explainerhttps://bit.ly/2SVvKbR >>>>>>> >>>>>> >>> The explainer seems focused on the H1 Origin Trial use case, which IIUC >>> we decided against. >>> Is there a more up-to-date explainer on what y'all are actually planning >>> to ship? >>> >> >> Oops, sorry again, I thought I updated the URL but apparently I failed to >> do so... >> Here it is. >> https://github.com/yutakahirano/fetch-with-streams/blob/master/streaming-upload.md >> > > Thanks! :) > >> >> >>> >>> >>>> >>>>>>> >>>>>>> Specificationhttps://fetch.spec.whatwg.org/#concept-body-stream >>>>>>> >>>>>>> Design docs >>>>>>> http://bit.ly/3asqra2 >>>>>>> >>>>>>> Summary >>>>>>> >>>>>>> Fetch upload streaming lets web developers make a fetch with a >>>>>>> ReadableStream body. Fetch provides a generic definition of Request and >>>>>>> Response objects (and other things involved with network requests). >>>>>>> >>>>>>> >>>>>>> Blink componentBlink>Network>FetchAPI >>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ENetwork%3EFetchAPI> >>>>>>> >>>>>>> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/434 >>>>>>> >>>>>> >>>>>> Actual review never really happened :/ Seems worthwhile to at least >>>>>> communicate that to the TAG. >>>>>> >>>>> >>>>> Oh sorry I somehow chose a wrong URL. >>>>> https://github.com/w3ctag/design-reviews/issues/754 is the correct >>>>> one. >>>>> >>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> TAG review statusIssues open >>>>>>> >>>>>>> Risks >>>>>>> >>>>>>> >>>>>>> Interoperability and Compatibility >>>>>>> >>>>>>> TBD >>>>>>> >>>>>>> >>>>>>> *Gecko*: No signal ( >>>>>>> https://github.com/mozilla/standards-positions/issues/207) >>>>>>> >>>>>> >>>>>> This seems like a position request for a different feature. I think >>>>>> you meant https://github.com/mozilla/standards-positions/issues/663 >>>>>> >>>>> >>> Seems like Mozilla are positive on this! (% some questions) >>> >>> >>>> >>>> You're right, thank you. >>>> >>>> >>>>> >>>>>> >>>>>>> No signals on the standards-position ticket. Annevk has been active >>>>>>> on the standards discussions. Positive at TPAC 2019 [1]. >>>>>>> >>>>>>> *WebKit*: No signal ( >>>>>>> https://github.com/WebKit/standards-positions/issues/24) No signals >>>>>>> on the standards-position ticket. Positive at TPAC 2019 [1]. [1] >>>>>>> https://docs.google.com/document/d/1q090ovJ4gd8wSfVtvuoZLMZ51YkiFDsEZ0Jiqi41Iys/edit#heading=h.85gziabhajhg >>>>>>> >>>>>>> *Web developers*: Positive >>>>>>> https://github.com/whatwg/fetch/issues/1438#issuecomment-1150755587 >>>>>>> https://github.com/whatwg/fetch/issues/1438#issuecomment-1167984830 >>>>>>> >>>>>>> *Other signals*: >>>>>>> >>>>>>> Security >>>>>>> >>>>>>> - Only 'cors' and 'same-origin' requests allow streaming upload. You >>>>>>> can't use streaming upload with 'navigate' and 'no-cors' requests. - >>>>>>> This >>>>>>> feature cannot be used with HTTP/1.x. If the server doesn't support >>>>>>> HTTP/2 >>>>>>> or HTTP/3, the request fails. This is for some compatibility concerns. >>>>>>> See >>>>>>> whatwg/fetch#966 for the past discussions. >>>>>>> >>>>>>> >>>>>>> WebView application risks >>>>>>> >>>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>>> that it has potentially high risk for Android WebView-based >>>>>>> applications? >>>>>>> >>>>>>> No >>>>>>> >>>>>>> >>>>>>> Debuggability >>>>>>> >>>>>>> Same as usual fetch() >>>>>>> >>>>>>> >>>>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)?Yes >>>>>>> >>>>>>> Is this feature fully tested by web-platform-tests >>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>> ?Yes >>>>>>> >>>>>>> Flag name >>>>>>> >>>>>>> Requires code in //chrome?False >>>>>>> >>>>>>> Tracking bug >>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=688906 >>>>>>> >>>>>>> Non-OSS dependencies >>>>>>> >>>>>>> Does the feature depend on any code or APIs outside the Chromium >>>>>>> open source repository and its open-source dependencies to function? >>>>>>> No >>>>>>> >>>>>>> Estimated milestones >>>>>>> OriginTrial desktop last 94 >>>>>>> OriginTrial desktop first 85 >>>>>>> >>>>>> >>>>>> Any learnings from the Origin Trials? >>>>>> >>>>> >>>> None. We had the origin trial to decide whether we want to allow the >>>> feature on HTTP/1.1. Here >>>> <https://github.com/whatwg/fetch/issues/966#issuecomment-586310657> is >>>> our intention at that time. >>>> Because of some technical problems we failed to collect the data and >>>> the partner (gRPC/web) lost their interest in the feature. >>>> >>>> Hence we decided to give up collecting the data. We asked web >>>> developers whether they want to use the feature even if we disable the >>>> feature on HTTP/1.1, and got some positive answers, as shown in >>>> https://github.com/whatwg/fetch/issues/1438#issuecomment-1150755587 >>>> and >>>> https://github.com/whatwg/fetch/issues/1438#issuecomment-1167984830. >>>> >>>> >>>>> >>>>>> >>>>>>> OriginTrial Android last 94 >>>>>>> OriginTrial Android first 85 >>>>>>> >>>>>>> Anticipated spec changes >>>>>>> >>>>>>> Open questions about a feature may be a source of future web compat >>>>>>> or interop issues. Please list open issues (e.g. links to known github >>>>>>> issues in the project for the feature specification) whose resolution >>>>>>> may >>>>>>> introduce web compat/interop risk (e.g., changing to naming or >>>>>>> structure of >>>>>>> the API in a non-backward-compatible way). >>>>>>> >>>>>>> >>>>>>> Link to entry on the Chrome Platform Status >>>>>>> https://chromestatus.com/feature/5274139738767360 >>>>>>> >>>>>>> Links to previous Intent discussionsIntent to Experiment: >>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/l7QI1bsq80Y/m/Z1TJ0nplAQAJ >>>>>>> >>>>>>> >>>>>>> This intent message was generated by Chrome Platform Status >>>>>>> <https://chromestatus.com/>. >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6GHAGHQvD5e9rwjgadjAf2bN8JJpkSBDndahLCHTqxp%3DQ%40mail.gmail.com >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6GHAGHQvD5e9rwjgadjAf2bN8JJpkSBDndahLCHTqxp%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUxtAEV2p0%2BV24FxUHxR35CDxMoxYexEEGmo033sPMsjg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUxtAEV2p0%2BV24FxUHxR35CDxMoxYexEEGmo033sPMsjg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfuoOoFm59Lh814x7qsFFcmPvSxUCBiiJQJvHQEa1mdVw%40mail.gmail.com.
