LGTM1 given the thorough analysis and my understanding based on it that the use counter is likely to be over-counting actual breakage. Thanks for running it! :)
On Thu, Jul 7, 2022 at 8:50 PM David Baron <[email protected]> wrote: > > > On Thu, Jul 7, 2022 at 10:36 AM David Baron <[email protected]> wrote: > >> Most relevant to this intent is the case on http://www.elster.de where >> default is used (which is the only actual site that I'm aware of this >> change affecting): it is a use in the animation-name property. The >> relevant chunk of CSS is the following (with newlines added): >> >> body{animation-name:default;animation-duration:1ms;content:'default'} >> @media screen and >> (min-width:20rem),print{body{animation-name:min;content:'min'}} >> @media screen and >> (min-width:30rem),print{body{animation-name:xs;content:'xs'}} >> @media screen and >> (min-width:48rem),print{body{animation-name:small;content:'small'}} >> @media screen and >> (min-width:60rem),print{body{animation-name:content;content:'content'}} >> @media screen and >> (min-width:60rem),print{body{animation-name:medium;content:'medium'}} >> @media screen and >> (min-width:80rem),print{body{animation-name:large;content:'large'}} >> @media screen and >> (min-width:105rem),print{body{animation-name:xl;content:'xl'}} >> @media screen and >> (min-width:120rem),print{body{animation-name:max;content:'max(a, b)'}} >> @keyframes >> default{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> min{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> xs{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> small{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> content{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> medium{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> large{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> xl{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> @keyframes >> max{from{clip:rect(1px,auto,auto,auto)}to{clip:rect(0,auto,auto,auto)}} >> >> This is rather a lot of CSS to apply the clip property to body for the >> first 1ms of the page's existence. I'm not sure why it's there, but maybe >> it's a workaround for something. In any case, this change would cause this >> chunk of CSS to no longer do whatever it does (which is likely not very >> much) for pages whose width is less than 20rem. >> >> elster.de has had >> <https://github.com/webcompat/web-bugs/issues?q=is%3Aissue+elster> a >> bunch of webcompat issues with Firefox, but none of the ones in that list >> seem related to this issue. >> > > And one further point about www.elster.de that I had forgotten about: > the clip property only applies to absolutely positioned elements, which > their body element is not. So whether or not default is valid as a > custom-ident, the above CSS should be 18 lines of no-op. > > -David > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUoDE6%3D8rZoC40022HAavqcEziTjTn8cO4vczWR1yGz3g%40mail.gmail.com.
