On Thursday, June 9, 2022 at 6:55:06 AM UTC+2 Manuel Rego wrote:
> I'm biased here as I've been working on this feature myself, so I cannot > give an official LGTM. > > Thanks for all the work since the previous intent thread, I believe this > is now in a way better status to ship. > > I'd be fine giving a LGTM with the following caveats: > * As mentioned at the end of the email, HighlightOverlayPainting flag > gets enabled before shipping this (that flag fixes lots of bugs > regarding paining of CSS highlight pseudos). > * The following CSSWG issue gets resolved: > https://github.com/w3c/csswg-drafts/issues/6774 > It looks like there's an agreement already but it'd be nice to confirm > it, as this might change behavior if a different decision is made. > > Other than that I've just some minor comments inline. > > On 08/06/2022 19:42, 'Daniel Clark' via blink-dev wrote: > > Risks > > > > > > Interoperability and Compatibility > > > > Low risk: This feature received positive support from Safari and Firefox > > at TPAC 2019. Safari is implementing it, Firefox has not yet made any > > clear indication on implementation. What's the feature detection/activation story here? Can developers use the feature while it's partially supported? What would be the implications of that? > > > > > > > > > /Gecko/: No clear signal > > (https://github.com/mozilla/standards-positions/issues/482 > > <https://github.com/mozilla/standards-positions/issues/482>) > > We could send a ping notifying that Chromium is planning to ship. > > > /WebKit/: Positive. WebKit implemented the feature behind an > > experimental flag in 99: > > > https://developer.apple.com/safari/technology-preview/release-notes/#:~:text=Added%20support%20for%20rendering%20highlights%20specified%20in%20CSS%20Highlight%20API > > > < > https://developer.apple.com/safari/technology-preview/release-notes/#:~:text=Added%20support%20for%20rendering%20highlights%20specified%20in%20CSS%20Highlight%20API>. > > > > I agree that it's positive WebKit has a WIP implementation. But just to > clarify the status Safari has an old version of this spec implemented, > and the implementation is not complete and not up to date regarding the > spec (e.g. https://bugs.webkit.org/show_bug.cgi?id=229797). Can you ask for an explicit signal to see what their plans are on that front? Is there an interop risk from their incomplete implementation? > > > Cheers, > Rego > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/47e226a2-d00a-42fd-a846-6f506969228an%40chromium.org.
