LGTM3 On Wed, Jan 5, 2022 at 6:17 PM Chris Harrelson <[email protected]> wrote:
> Alex replied with LGTM1 in another thread on blink-dev: "LGTM, however > this should be sent to the TAG as an FYI. It's new design language that > they will want/need to be aware of when considering other reviews. There > isn't a carveout for TAG review for CSS." > > LGTM2 from me. > > On Wed, Dec 15, 2021 at 5:42 PM Seokho Song <[email protected]> wrote: > >> >> >> On Thursday, December 16, 2021 at 9:16:54 AM UTC+9 Seokho Song wrote: >> >>> Hi, mike! Thanks for response :) >>> On Saturday, December 11, 2021 at 3:39:16 PM UTC+9 [email protected] >>> wrote: >>> >>>> Hi Seokho, >>>> >>>> Thanks for working on this! >>>> >>>> On 12/9/21 6:56 PM, Seokho Song wrote: >>>> >>>> Contact emails >>>> >>>> [email protected] >>>> >>>> Explainer >>>> >>>> https://github.com/DevSDK/calc-infinity-and-NaN/blob/master/explainer.md >>>> >>>> Specification >>>> >>>> >>>> https://drafts.csswg.org/css-values/#ref-for-math-function%E2%91%A1%E2%91%A0 >>>> >>>> Design docs >>>> >>>> https://bit.ly/349gXjq >>>> >>>> Summary >>>> >>>> CSS calc() math function should allow infinity and NaN values by >>>> 'infinity', '-infinity', 'NaN' keywords or expressions that could be >>>> evaluated into infinity or NaN such as 'calc(1/0)'. >>>> >>>> >>>> Blink component >>>> >>>> Blink>CSS >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> >>>> >>>> Search tags >>>> >>>> css <https://chromestatus.com/features#tags:css>, calc >>>> <https://chromestatus.com/features#tags:calc>, infinity >>>> <https://chromestatus.com/features#tags:infinity>, nan >>>> <https://chromestatus.com/features#tags:nan> >>>> >>>> TAG review >>>> >>>> Not required. It's a very small part of CSS. >>>> >>>> TAG review status >>>> >>>> Not applicable >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> This feature may have interoperability risks. Other browsers have not >>>> yet implemented this feature. >>>> >>>> Looking at >>>> https://wpt.fyi/results/css/css-values?label=master&label=experimental&aligned&q=infinity-nan, >>>> it seems like Chrome and Safari disagree on handling a top-level >>>> calculation that produces NaN, like "calc(NaN * 1px)" - I think we're >>>> treating it as positive Infinity, and they seem to be treating as >>>> (unsigned?) zero? >>>> >>>> I filed https://bugs.webkit.org/show_bug.cgi?id=234176 to track that. >>>> >>>> Gecko: No signal (https://bugzilla.mozilla.org/show_bug.cgi?id=1682444) >>>> >>>> Can you please request a position? https://bit.ly/blink-signals >>>> >>> >>> Sure. I've filed on >>> https://github.com/mozilla/standards-positions/issues/602. >>> But not yet responded. >>> >>> >>>> >>>> WebKit: Shipped/Shipping ( >>>> https://bugs.webkit.org/show_bug.cgi?id=231044) >>>> >>>> Web developers: No signals >>>> >>>> Other signals: >>>> >>>> >>>> Debuggability >>>> >>>> N/A >>>> >>>> DevTools should support this out of the box, I think. >>>> >>> >>> Can I ask what features or supports we need on devtools? >>> What do I need some action on it? >>> >> >> For this project, the degenerate values are correctly reflected when we >> inspect the style of an element. >> >> I think DevTools is already supporting this. No extra work is needed. >> >> >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>> ? >>>> >>>> Yes >>>> >>>> >>>> Flag name >>>> >>>> Requires code in //chrome? >>>> >>>> False >>>> >>>> Tracking bug >>>> >>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1133390 >>>> >>>> Estimated milestones >>>> >>>> 99 >>>> >>>> >>>> Link to entry on the Chrome Platform Status >>>> >>>> https://chromestatus.com/feature/5657825571241984 >>>> >>>> Links to previous Intent discussions >>>> >>>> Intent to prototype: >>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/4cT9dMkzVXE/m/aCT8B6PDAwAJ >>>> >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f98064ee-9d8a-44a5-bf37-4a32a5471496n%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f98064ee-9d8a-44a5-bf37-4a32a5471496n%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c10dbce3-19ef-462b-965e-b5e5a851e7b1n%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c10dbce3-19ef-462b-965e-b5e5a851e7b1n%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8Wkz6eTEMXWxB2JLKir6LaVgeo9URdN%3DRsANDKRxJMVw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8Wkz6eTEMXWxB2JLKir6LaVgeo9URdN%3DRsANDKRxJMVw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXTmtVOfmUXT3jsJ9L%2BxUOO3a8GasqwM48j2nJtZd7t5A%40mail.gmail.com.
