LGTM3
On Tue, Dec 14, 2021 at 8:22 AM Chris Harrelson <[email protected]> wrote: > LGTM2 > > On Mon, Dec 13, 2021 at 3:19 PM Frank Tang <[email protected]> wrote: > >> Dear API owners: >> [Five days after my I2S email] >> Any questions or feedback I should/need to take action before you grant >> me a lgtm? >> >> Thanks >> >> Regards, >> Frank Tang >> >> On Mon, Dec 13, 2021 at 3:12 PM Frank Tang <[email protected]> wrote: >> >>> >>> >>> On Mon, Dec 13, 2021 at 9:14 AM Mike Taylor <[email protected]> >>> wrote: >>> >>>> LGTM1 >>>> >>>> On 12/8/21 1:46 PM, Frank Tang wrote: >>>> >>>> [for m99 AFTER m98 branching off Dec 9, 2021] >>>> >>>> Contact emails [email protected] >>>> >>>> Explainer https://github.com/tc39/proposal-intl-enumeration >>>> >>>> Specification https://tc39.es/proposal-intl-enumeration/ >>>> >>>> Design docs >>>> design doc >>>> <https://chromestatus.com/admin/features/launch/5649454590853120/design%20doc> >>>> >>>> https://docs.google.com/document/d/1lbj_YVW-xhzYNMQeHB-qDjVkf4SA-eTHYpYXx3Oaud8 >>>> Update slides for TC39 2021-Dec-15 >>>> <https://chromestatus.com/admin/features/launch/5649454590853120/Update%20slides%20for%20TC39%202021-Dec-15> >>>> >>>> https://docs.google.com/presentation/d/1wR8Yg3JVwa1RAPgQGqUPsRtP0EeMXy_Q8zqgRIKRiQI >>>> >>>> Summary >>>> >>>> Intl Enumeration API Specification is a new ECMA402 Stage 3 proposal >>>> which lists supported values of options in pre-existing API. >>>> >>>> >>>> Blink component Blink>JavaScript>Internationalization >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3EInternationalization> >>>> >>>> TAG review >>>> >>>> TAG review status Not applicable >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> The API add a new method to pre-exist Intl method to expose available >>>> values for some of the option and should improve interoperability between >>>> Intl object and help web developer to figure out compatability issues >>>> between browers. >>>> >>>> >>>> Gecko: Shipped/Shipping ( >>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1670033) 93 >>>> >>>> WebKit: Shipped/Shipping ( >>>> https://bugs.webkit.org/show_bug.cgi?id=214795) Release 132 of Safari >>>> Technology Preview >>>> https://developer.apple.com/safari/technology-preview/release-notes/ >>>> >>>> Web developers: No signals ( >>>> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf) >>>> MDN link >>>> >>>> Other signals: >>>> >>>> Ergonomics >>>> >>>> The return result of the newly added API could be used to call >>>> pre-existing ECMA402 API. >>>> >>>> >>>> Activation >>>> >>>> Should be straightforward since it is adding a new method to pre-exist >>>> Intl object and leverage pre-existing concept and property key and values. >>>> >>>> >>>> Debuggability >>>> >>>> This will help web developer to debug issues since it provide all >>>> available values for pre-existing function. >>>> >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>> ? Yes >>>> >>>> Non-blocking question: it seems like the v8 tests we landed for this >>>> API aren't in https://test262.report/browse/intl402 - do we eventually >>>> upstream those? (Or is the intel402 directory governed by some other >>>> process or WG?) >>>> >>> >>> the tests for test262 tests are in >>> https://test262.report/browse/intl402/Intl/supportedValuesOf >>> >>> It is 0% for v8 now because we have not flip this bit and should pass >>> all once the bit flip. >>> >>>> >>>> Flag name --harmony_intl_enumeration >>>> >>>> Requires code in //chrome? False >>>> >>>> Tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=10743 >>>> >>>> Estimated milestones >>>> DevTrial on desktop 95 >>>> DevTrial on android 95 >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5649454590853120 >>>> >>>> Links to previous Intent discussions Intent to prototype: >>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/Txtf_rSqGH8/m/e27FY33JAQAJ >>>> Ready for Trial: >>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/IaTkvH_9DAY/m/1rDxe8lvAAAJ >>>> Intent to Experiment: >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8bV%3DJ1jqt-YK69%3DUqZTurERu%2BnM98J37dZTXQmGdaB2w%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8bV=J1jqt-YK69=uqztureru+nm98j37dztxqmgda...@mail.gmail.com> >>>> >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL9xicjAg64Dqy9BOCMFMZ8V5S5LMdPKAJ3QL-S3xhB4FQ%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL9xicjAg64Dqy9BOCMFMZ8V5S5LMdPKAJ3QL-S3xhB4FQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8tobxcsTzdmoW%3Da%3DQ67ozMOE0Lj6LhfJd7%3D7Tc7ro2mA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8tobxcsTzdmoW%3Da%3DQ67ozMOE0Lj6LhfJd7%3D7Tc7ro2mA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- TAMURA Kent Software Engineer, Google -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHr-YL9LsPv531PrGVbT%3DyLBzbvq-%3DrT9nJJFQtU%3Dw4DA%40mail.gmail.com.
