On Fri, 2020-05-15 at 15:58 -0500, Bruce Dubbs via blfs-dev wrote:
> On 5/15/20 2:40 PM, Pierre Labastie via blfs-dev wrote:
> > On Fri, 2020-05-15 at 13:42 -0500, Bruce Dubbs via blfs-dev wrote:
> > > On 5/15/20 12:54 PM, Pierre Labastie via blfs-dev wrote:
> > > > On Fri, 2020-05-15 at 12:31 -0500, Bruce Dubbs via blfs-dev
> > > > wrote:
> > > > > On 5/15/20 8:16 AM, Pierre Labastie via blfs-dev wrote:
> > > > > > libmusibrainz fails early with:
> > > > > > ---
> > > > > > make[2]: *** No rule to make target 'src/*.inc', needed by
> > > > > > 'src/mb5_c.cc'.  Stop.
> > > > > > ---
> > > > > > It looks like there is an upstream commit
> > > > > > https://github.com/metabrainz/libmusicbrainz/commit/8be45b12a86bc0e46f2f836c8ac88e1e98d82aee
> > > > > > 
> > > > > > I've verified it allows building.
> > > > > > It can be applied with:
> > > > > > ----
> > > > > > pushd src
> > > > > > sed 's/\*\.inc/'"$(echo *.inc)"/ -i CMakeLists.txt
> > > > > > popd
> > > > > > ----
> > > > > > 
> > > > > > But I am amazed nobody has seen this yet. It must be a new
> > > > > > oddity
> > > > > > with
> > > > > > recent cmake...
> > > > > 
> > > > > I saw it, but skipped it until now.  Updated the above with:
> > > > > 
> > > > > sed -i 's/\*\.inc/"$(echo *.inc)"/' src/CMakeLists.txt
> > > > > 
> > > > >      -- Bruce
> > > > 
> > > > Doesn't work: "echo *.inc" returns the list of .inc files in
> > > > the
> > > > current directory (which is empty if you do not change dir, I
> > > > think).
> > > > And if you put src/*.inc, they are prefixed with src, which is
> > > > not
> > > > right.
> > > 
> > > Worked for me.  Note that you are modifying src/CMakeLists.txt
> > > and
> > > that
> > > doesn't run the echo until cmake is run.
> > > 
> > 
> > Ah, you moved the single quote... But I won't trust cmake to keep
> > this
> > valid: having a bash command inside a CMakeLists.txt. The behavior
> > already changed from expanding to not expanding *.inc... That's why
> > we
> > need a sed.
> 
> We will only need this until the next version is released.
> 

Last version is from 2014. The change to src/CMakeLists.txt has been
done in 2018, and there is no release since then. So maybe next release
is not coming soon :)

Pierre

-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to