On Mon, Dec 09, 2019 at 10:37:53PM -0600, Bruce Dubbs via blfs-dev wrote:
> On 12/9/19 8:00 PM, Ken Moffat via blfs-dev wrote:
> > On Mon, Dec 09, 2019 at 03:40:24PM -0600, Douglas R. Reno via blfs-dev
> > wrote:
> > >
> > > On 12/9/19 2:22 PM, Alain Dumont via blfs-dev wrote:
> > > > Le 09/12/2019 à 20:20, Ken Moffat via blfs-dev a écrit :
> > > > > On Mon, Dec 09, 2019 at 04:19:12PM +0100, Alain Dumont via blfs-dev
> > > > > wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > In the instructions for Qtwebengine you propose to use the
> > > > > > instruction
> > > > > > NINJAJOBS = x to avoid some problems.
> > > > > > This variable, defined in the Ninja patch of LFS collides with
> > > > > > the present
> > > > > > variable in ../src/core/gn_run.pro of the qtwebengine package,
> > > > > > which causes strange compilation errors.
> > > > > >
> >
> > So now the position appears to be:
> >
> > if you have patched system ninja to use NINJAJOBS=N, for qtwebengine
> > you should change the value to NINJAJOBS=-jN. Similarly,
> > NINJAJOBS=-jN should work even if you have not patched system ninja.
> >
> > I'll let this build run, to be sure.
> >
> > I suppose we could just add a note something like:
> >
> > Unlike other packages which use ninja, qtwebengine now accepts
> > a specification for how many jobs to use, in environmant variable
> > NINJAJOBS. But the value has to be in the -jN format, e.g
> > NINJAJOBS=-j2, unlike the form normally used with the patch which
> > LFS uses for ninja.
> >
> > I might be over-thinking this, but I don't want to mention both
> > NINJAJOBS=-j2 and NINJAJOBS=2 in the that last sentence.
>
> What if we just change qtwebengine:
>
> sed -i 's/NINJAJOBS/NINJA_JOBS/' src/core/gn_run.pro
>
> -- Bruce
>
I prefer that. Concise, and safe. Committed, r22459.
ĸen
--
We've all got both light and dark inside of us.
What matters is the part we choose to act on.
-- Sirius Black
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
