Dear Tim,
On 12.07.19 06:43, Tim Tassonis via blfs-dev wrote:
On 7/12/19 1:08 AM, Bruce Dubbs via blfs-dev wrote:
On 7/11/19 5:28 PM, Ken Moffat via blfs-dev wrote:
On Thu, Jul 11, 2019 at 11:39:23PM +0200, Tim Tassonis wrote:
As you can see in my mail headers, I now managed to compile
thunderbird-60.8.0 with rustc 1.35.0, using the following two sed
commands:
sed -i -e '/#!\[deny(missing_docs)\]/d' servo/components/style/lib.rs
sed -i -e 's/#!\[deny(unsafe_code,
missing_docs)\]/#!\[deny(unsafe_code)\]/g'
servo/components/style_traits/lib.rs
Will put them in the book.
Well done! I'm sorry 60.8.0 interacted worse with 1.35.0 than 60.7.
Yes, well done. Just a thought to make the seds simpler:
One instance:
sed -i 's/, missing_docs//' servo/components/style_traits/lib.rs
Two instances:
sed -i '/deny.missing/d' servo/components/style/lib.rs
Yes, I quite suck at regular expressions, I know.
Thank you very much for posting your findings. My suggested fix was
indeed only for Thunderbird 60.7.2.
On a side note: I find it quite "interesting" that the latest releases
of mozilla's flagship applications cannot be compiled with the same
tool-chain without modification. Firefox complained about rustc 1.32
being too old and thunderbird needs a patch for newer versions than 1.32.
Could you please report the failure for the Rust crate *style_traits*
upstream? I did it for the crate *style* [1], and after some discussion
they submitted a fix, which did not make it into 60.8.0 though.
The upstream Mozilla folks seem to only test with a very narrow subset
of tool chain versions. Maybe we can get them to extend their build
matrix to also test with the latest Rust version in addition to the one,
when the corresponding Firefox ESR release was made.
Also, I still haven’t found good documentation about the Mozilla
Thunderbird release cycle. It looks like, they only release Betas for
the versions between ESR versions.
But still two great pieces of software, worth that hassle.
Seconded.
Kind regards,
Paul
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1561926
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
