On Thu, Aug 23, 2018 at 05:48:57PM -0500, Bruce Dubbs wrote:
> I didn't get this on gmail either.
> ----------------------
>
> I built vlc a week or so ago on BLFS-svn-20180808, using the
> previous (February) x264 snapshot. With the current snapshot, vlc
> fails to build:
>
> CC codec/libx264_plugin_la-x264.lo
> codec/x264.c: In function 'Open':
> codec/x264.c:849:26: error: 'x264_bit_depth' undeclared (first use in this
> function); did you mean 'x264_picture_t'?
> const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
> ^~~~~~~~~~~~~~
> x264_picture_t
> codec/x264.c:849:26: note: each undeclared identifier is reported only once
> for each function it appears in
> make[4]: *** [Makefile:22479: codec/libx264_plugin_la-x264.lo] Error 1
>
> I had failed to build the newer x264 a couple of days ago (thought I'd
> picked it
> up, but I hadn't), so today I picked it up and compared: version was
> 152, now 155 (and everything using it links to the exact version, so
> I had to also recompile gst-plugins-ugly, ffmpeg, transcode).
>
> Possible patch at https://patches.videolan.org/patch/19895/ which
> can be achieved with:
>
> sed -i 's/\(>= 118\)/\1 \&\& X264_BUILD < 153/' modules/codec/x264.c
>
> That fixes it.
>
> What I find WORRYING about this is that vlc has already been tagged
> for 8.3.
>
> I suppose somebody built it without x264, which is labelled as
> optional, but not using x264 seems pointless to me (a lot of videos
> use Advanced Video Codec from h264 or x264, particularly mp4
> videos).
>
> ĸen
> ===========
>
> Ken, it is already fixed.
> Check your script against the book.
>
> -- Bruce
OK, I'll take your word for it. But the mix of new versions,
consequential but undocumented changes, and tags is why I hate
trying to test releases.
ĸen
--
Entropy not found, thump keyboard to continue
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
