On 20/04/2018 08:24, Bruce Dubbs wrote: > On 04/19/2018 03:38 PM, Ken Moffat wrote: >> On Wed, Apr 18, 2018 at 09:08:34PM -0500, Bruce Dubbs wrote: >>> On 04/18/2018 07:25 PM, Ken Moffat wrote: >>>> I don't build gptfdisk on some of my machines, so I didn't notice >>>> this until now. Building gptfdisk with 'make ICU=1 POPT=1' fails: >>>> >>>> g++ -O2 -march=native -Wall -D_FILE_OFFSET_BITS=64 -DUSE_UTF16 -c -o >>>> mbr.o mbr.cc >> [...] >>>> gptpart.h:84:26: error: 'UnicodeString' does not name a type; did you mean >>>> 'ReadString'? >>>> void SetName(const UnicodeString & theName); >>>> ^~~~~~~~~~~~~ >>>> ReadString >>>> make: *** [<builtin>: mbr.o] Error 1 >>>> >>>> If I don't pass ICU=1 it builds. >>>> >>>> Looking at fedora, arch, gentoo, debian (at least fedora and debian >>>> seem to call it gdisk) I see nothing like the patch we are carrying, >>>> they just build it as upstream designed (although there seem to be >>>> fixes for ncursesw5 in gentoo and debian). >>>>
From the README file for gptfdisk: " The ICU library (http://site.icu-project.org), which provides support for Unicode partition names, is optional on all platforms except Windows, on which it's not supported. Using this library was required to get proper UTF-16 partition name support in GPT fdisk versions prior to 0.8.9, but as of that version it should not longer be required." >>> I wrote that patch for convenience. It makes the build simpler. >>> 'make ICU=1 POPT=1' works fine for me. Not for me (fresh LFS build, icu_61.1): I get the same error as Ken. Actually, the gptfdisk sources now provide unicode conversion (if USE_UTF16 is *not* defined), and does not use icu anymore. I'll regenerate a patch and change the book instructions. >> >> [...] Regards Pierre -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
