Ticket #5391 suggests using the ip command for bridge functions in the services part of the boot script. For instance, it suggests changing

brctl addbr ${1}

to

ip link add name ${1} type bridge
ip link set dev ${1} up
===============
Changing

brctl stp ${1} on

to

echo 1 > /sys/class/net/${1}/bridge/stp_state
==============
Changing

brctl delif ${1} ${I}

to

ip link set ${I} nomaster
==============
Cahnging

brctl delbr ${1}

to

ip link delete ${1}
=============

I can see both advantages and disadvantages to this. For advantages, it means that the bridge-utils package is not needed.

For disadvantages, the new commands are slightly more complex. We also only install the bridge service script in the bridge-utils section of the book, so that would need to be moved.

The only place we actually use a bridge is with qemu and that specifically calls brctl in the network scripts.

We could move the modified bridge service to the LFS bootscripts and always install it.

My preference is to leave things as they are. I don't see much advantage to dropping bridge-utils. It's a very fast build (2 seconds in my log) and provides a pretty clear manpage. What we have works, and the changes needed would be fairly invasive.

Thoughts?

  -- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to