Display of an incorrect value in BFD "Remote state" in BIRD 3.1.3

[Andrey Ziltsov]

Hello.

I noticed an issue in BIRD version 3.1.3 with the display of the "Remote
state" when showing the status of a BFD session. For all BFD sessions, the
state is shown as "Remote state: Init".

For example:

# birdc show bfd sessions address 195.208.208.100 all
BIRD 3.1.3 ready.
bfd_v6:

bfd_v4:
  Address:              195.208.208.100
  Interface:            vlan701
  Session type:         Direct
  Session state:        Up
  *Remote state:         Init*
  Last state change:    11:32:02.130
  Local diagnostic:     None
  Remote diagnostic:    None
  Local discriminator:  XXXXXXXX
  Remote discriminator: XXXXXXXX
  Transmit timer:       0.698 / 1.000
  Detect timer:         4.234 / 5.000
  Local parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5
  Remote parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5

At the same time, in version BIRD 3.1.2 it is displayed as follows:

# birdc show bfd sessions address 195.208.208.100 all
BIRD 3.1.2 ready.
bfd_v6:

bfd_v4:
  Address:              195.208.208.100
  Interface:            vlan701
  Session type:         Direct
  Session state:        Up
  *Remote state:         Up*
  Last state change:    11:29:29.994
  Local diagnostic:     None
  Remote diagnostic:    None
  Local discriminator:  XXXXXXXX
  Remote discriminator: XXXXXXXX
  Transmit timer:       0.729 / 1.000
  Detect timer:         4.596 / 5.000
  Local parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5
  Remote parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5

In BIRD version 2.17.2 the state is displayed as:

# birdc show bfd sessions address 195.208.208.100 all
BIRD 2.17.2 ready.
bfd_v4:
  Address:              195.208.208.100
  Interface:            vlan701
  Session type:         Direct
  Session state:        Up
  *Remote state:         Up*
  Last state change:    10:07:54.557
  Local diagnostic:     None
  Remote diagnostic:    None
  Local discriminator:  XXXXXXXX
  Remote discriminator: XXXXXXXX
  Transmit timer:       0.651 / 1.000
  Detect timer:         4.550 / 5.000
  Local parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5
  Remote parameters:
    Min TX interval:    1.000
    Min RX interval:    1.000
    Demand mode:        No
    Multiplier:         5

It seems that in BIRD 3.1.3 the "Remote state" is displayed incorrectly.