On 06/10/2014 11:18 μμ, Ondrej Zajicek wrote: > On Sun, Oct 05, 2014 at 09:47:08PM +0200, Pavlos Parissis wrote: >> Hi, >> >> This another patch for the init script which adds a check_config >> function and call it prior of, start and reload. > > Hi > > Why to do this?
Because it is needed for integration with configuration management tools(Puppet, chef and etc). Without the patch these tools are unaware that they just pushed a broken configuration. Bird operation is not effected as it doesn't load broken configuration. > Explicit checking of config has some specific use cases > but it is IMHO pointless in standard init scripts. If we need return > values (to see if BIRD was properly started or reconfigured), we should > get proper return values from the primary commands (that means that > 'birdc configure' should be used for reconfiguration instead of sending > HUP and i should ensure that birdc returns proper error code) > I was wondering why init script was not calling birdcl configure rather sending HUP, but I guess because it is not actively used/maintained. What would be the consequence of sending HUP rather calling birdcl configure, if any? Thanks, Pavlos
signature.asc
Description: OpenPGP digital signature
