On Friday, 17 August 2018 2:47:37 PM AEST Chris Samuel wrote: > Just a heads up that the 3.10.0-862.11.6.el7.x86_64 kernel from RHEL/CentOS > that was released to address the most recent Intel CPU problem "L1TF" seems > to break RDMA (found by a colleague here at Swinburne).
So this CentOS bug has a one line bug fix for this problem! https://bugs.centos.org/view.php?id=15193 It's a corker - basically it looks like someone typo'd a ; into an if statement, the fix is: - if (!rdma_is_port_valid_nospec(device, &ah_attr->port_num)); + if (!rdma_is_port_valid_nospec(device, &ah_attr->port_num)) return -EINVAL; So it always returns -EINVAL when checking the port as the if becomes a noop.. :-( Patch attached... -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
>From 6353587a7efa488a4064f3661cf64bd4d74eaa73 Mon Sep 17 00:00:00 2001 From: Pablo Greco <psgr...@gmail.com> Date: Mon, 20 Aug 2018 06:39:55 -0300 Subject: [PATCH] OMG!!!! --- drivers/infiniband/core/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index debe718..c080eb2 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -1232,7 +1232,7 @@ int ib_resolve_eth_dmac(struct ib_device *device, int ret = 0; struct ib_global_route *grh; - if (!rdma_is_port_valid_nospec(device, &ah_attr->port_num)); + if (!rdma_is_port_valid_nospec(device, &ah_attr->port_num)) return -EINVAL; if (ah_attr->type != RDMA_AH_ATTR_TYPE_ROCE) -- 1.8.3.1
_______________________________________________ Beowulf mailing list, Beowulf@beowulf.org sponsored by Penguin Computing To change your subscription (digest mode or unsubscribe) visit http://www.beowulf.org/mailman/listinfo/beowulf
