> -----Original Message----- > From: Beignet [mailto:[email protected]] On Behalf Of > Rebecca N. Palmer > Sent: Friday, March 31, 2017 2:37 PM > To: [email protected] > Subject: Re: [Beignet] [PATCH newRT] Add cl_gen_device_common.h file. > > +#ifdef ENABLE_OPENCL_20 > +.address_bits = 64, > +#else > +.address_bits = 32, > +#endif > > Should that be 32 unconditionally, like it now is in master? > https://lists.freedesktop.org/archives/beignet/2017-February/008565.html
I think a better choice is to make OpenCL 1.2 also use 64bit address. So that we have a unified address_bits across 1.2 and 2.0. But using 64bit address would hurt some performance. I think we need more work on 64bit optimization to make "unified address_bits across different ocl version" affect as less as we can. Before that happened, I don't have any preference. I am not sure if you have any concern over this? Or any one affected by this? Thanks! Ruiling > _______________________________________________ > Beignet mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/beignet
