> -----Original Message----- > From: Beignet [mailto:[email protected]] On Behalf Of > Yang Rong > Sent: Friday, January 6, 2017 10:59 PM > To: [email protected] > Cc: Yang, Rong R <[email protected]> > Subject: [Beignet] [PATCH] GBE: fix two mix pointer bug. > > 1. When update pointerOrigMap, only non-select and non-phi insn need > update second[0], if update select or phi's second[0], will over write the > info. > 2. For legacy A64 mix pointer, tmp register is start from insn.extra.elem. > > Signed-off-by: Yang Rong <[email protected]>
The code LGTM. But I think it will be better to split as two patches. And you need to change the commit message. This is not related to A64. - Ruiling _______________________________________________ Beignet mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/beignet
