> -----Original Message----- > From: Beignet [mailto:[email protected]] On Behalf Of > Yang Rong > Sent: Thursday, December 29, 2016 6:32 PM > To: [email protected] > Cc: Yang, Rong R <[email protected]> > Subject: [Beignet] [Patch V2] GBE: correct the llvm.loop.unroll.enable meta. > > LLVM check has meta llvm.loop.unroll.enable and > llvm.loop.unroll.disable or not. > If llvm.loop.unroll.disable and llvm.loop.unroll.enable are both set, > llvm.loop.unroll.disable will override llvm.loop.unroll.enable. > > V2: don't add meta when not enable unroll, let llvm unroll pass to > decide. I think it is good to let llvm unroll pass to make the decision, that is through passing the expected unroll parameters. We only try to optimize what we really want to unroll in this pass. The patch LGTM.
- Ruiling _______________________________________________ Beignet mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/beignet
