2016-12-21 10:43 GMT+08:00 Pan, Xiuli <[email protected]>: > I got the point. > In some case, such as block read gemm. We may get 16 mad with g4, thus > there may be some other mad using g4.2 or g4.3 later. > If we reuse the g4, the g4.2 or g4.3 may be overwrite. In this case may be > g4.1 is just a scalar value, and g4.2 or g4.* can be some other scalar > value. This fix check if the src and dst is all uniform. It should fix this > case. > > but the original code only change the liveness of the g4.1 instead of directly re-use the source. So the problems is that liveness is wrong for other scalar registers?
- Ruiling > -----Original Message----- > From: Beignet [mailto:[email protected]] On Behalf Of > Song, Ruiling > Sent: Tuesday, December 20, 2016 8:28 PM > To: Yang, Rong R <[email protected]>; [email protected] > Cc: Yang, Rong R <[email protected]> > Subject: Re: [Beignet] [PATCH] GBE: fix a src/dst register reuse bug. > > > > > -----Original Message----- > > From: Beignet [mailto:[email protected]] On Behalf > > Of Yang Rong > > Sent: Tuesday, December 20, 2016 4:47 PM > > To: [email protected] > > Cc: Yang, Rong R <[email protected]> > > Subject: [Beignet] [PATCH] GBE: fix a src/dst register reuse bug. > > > > For case: > > mad(8) g4<1>:F g4.1<0,1,0>:F g127.7<0,1,0>:F g46:F > > src0 is uniform, dst is non-uniform, dst can't reuse the src0. > why g4.0 cannot be reused here? What's wrong here? > > _______________________________________________ > Beignet mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/beignet > _______________________________________________ > Beignet mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/beignet >
_______________________________________________ Beignet mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/beignet
