The functions sinh, cosh, tanh and log1p were failing because log1p was failing. Log1p was failing due to translation of a*b+c in mad (a, b, c). I have fixed the log1p implementation. Errors were less in patch 5 (with CLC) because sinh, cosh don't use log1p in the CLC variant (as oposed to patch 4 -fdlibm).
I will repost only the first 4 patches. The CLC functions (patch 5) can anytime be used on top of patch 4 if we are sure there are no copyright issues. -----Original Message----- From: Yang, Rong R Sent: Friday, June 24, 2016 1:18 PM To: Lupescu, Grigore <[email protected]>; Song, Ruiling <[email protected]>; [email protected] Subject: RE: [Beignet] [PATCH 4/5] Backend: Optimization internal math, use mad Can you compare the LLVM IR/GEN IR/ASM between the IVB and HSW, use same version llvm, maybe could quick find the root cause. > -----Original Message----- > From: Lupescu, Grigore > Sent: Friday, June 24, 2016 1:16 > To: Yang, Rong R <[email protected]>; Song, Ruiling > <[email protected]>; [email protected] > Subject: RE: [Beignet] [PATCH 4/5] Backend: Optimization internal > math, use mad > > I confirm some tests are failing for IVB architecture. I am looking > into this issue. > > I ran the conformance on IVB i7-3770K (patchset 1,2,3,4 - without the > patch 5 > clc) which gave: FAILED 4 of 98 tests i.e. failed on log1p, atanh, cosh, sinh. > Changes to those functions are done in patch 4. Applying only first 3 > patches results in all tests passing for IVB. > > I did not experience any of these failures on HSW or BDW architecture. > > -----Original Message----- > From: Yang, Rong R > Sent: Thursday, June 23, 2016 9:13 AM > To: Song, Ruiling <[email protected]>; Lupescu, Grigore > <[email protected]>; [email protected] > Subject: RE: [Beignet] [PATCH 4/5] Backend: Optimization internal > math, use mad > > This patchset will cause some math utests fail in IVB, such as > builtin_acos_asin, builtin_lgamma_float and so on. > > > -----Original Message----- > > From: Beignet [mailto:[email protected]] On > > Behalf Of Song, Ruiling > > Sent: Monday, June 6, 2016 16:39 > > To: Lupescu, Grigore <[email protected]>; > > [email protected] > > Subject: Re: [Beignet] [PATCH 4/5] Backend: Optimization internal > > math, use mad > > > > The first four patches look good. But personally I don't think the > > 5th patch is proper for merge, although I am not good at copyright topics. > > > > Thanks! > > Ruiling > > _______________________________________________ > > Beignet mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/beignet
