LGTM, pushed, thanks.
> -----Original Message----- > From: Beignet [mailto:[email protected]] On Behalf Of > Ruiling Song > Sent: Sunday, September 6, 2015 15:12 > To: [email protected] > Cc: Song, Ruiling > Subject: [Beignet] [PATCH] GBE: add check dumpASMFileName.empty() > > Signed-off-by: Ruiling Song <[email protected]> > --- > backend/src/backend/program.cpp | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/backend/src/backend/program.cpp > b/backend/src/backend/program.cpp index d9e6416..e75e911 100644 > --- a/backend/src/backend/program.cpp > +++ b/backend/src/backend/program.cpp > @@ -847,11 +847,14 @@ namespace gbe { > clangErrSize = *errSize; > } > > - FILE *asmDumpStream = fopen(dumpASMFileName.c_str(), "w"); > - if (asmDumpStream) > - fclose(asmDumpStream); > - p = gbe_program_new_from_llvm(deviceID, NULL, out_module, > llvm_ctx, dumpASMFileName.c_str(), stringSize, > - err, errSize, optLevel); > + if (!dumpASMFileName.empty()) { > + FILE *asmDumpStream = fopen(dumpASMFileName.c_str(), "w"); > + if (asmDumpStream) > + fclose(asmDumpStream); > + } > + p = gbe_program_new_from_llvm(deviceID, NULL, out_module, > llvm_ctx, > + dumpASMFileName.empty() ? NULL : > dumpASMFileName.c_str(), > + stringSize, err, errSize, > + optLevel); > if (err != NULL) > *errSize += clangErrSize; > if (OCL_OUTPUT_BUILD_LOG && options) > -- > 2.3.1 > > _______________________________________________ > Beignet mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
