The patchset LGTM.
But still I have some comments. The patchset work for clBuildProgram().
But you don't handle clCompileProgram() and clLinkProgram(). You need to 
double-check whether this is needed.
If needed, you have to refine the dump-llvm logic into BuildModuleFromSource, 
so that build/compile both share the logic.
And the dump-asm logic will be also needed in genProgramBuildFromLLVM()

Thanks!
Ruiling
_______________________________________________
Beignet mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/beignet

Reply via email to