Other parts in the patchset looks good. -----Original Message----- From: Gong, Zhigang Sent: Friday, September 12, 2014 4:44 PM To: Song, Ruiling; Zhigang Gong Cc: [email protected] Subject: RE: [Beignet] [PATCH 1/3] GBE: fix multiple files compilation bugs.
That's ok. Any other comments? > -----Original Message----- > From: Song, Ruiling > Sent: Friday, September 12, 2014 4:38 PM > To: Zhigang Gong; Gong, Zhigang > Cc: [email protected] > Subject: RE: [Beignet] [PATCH 1/3] GBE: fix multiple files compilation bugs. > > You can put below words in the comment, so others know it: > Clang abort to compile and generate the following error message. > "Global is external, but doesn't have external or weak linkage" > > -----Original Message----- > From: Zhigang Gong [mailto:[email protected]] > Sent: Friday, September 12, 2014 4:28 PM > To: Song, Ruiling; Gong, Zhigang > Cc: [email protected] > Subject: RE: [Beignet] [PATCH 1/3] GBE: fix multiple files compilation bugs. > > Clang abort to compile and generate the following error message. > "Global is external, but doesn't have external or weak linkage" > > This is indeed a temporary workaround solution so I put a XXX there. > Just like those linked_once fixed-up solution, these are all temporary > solutions, right? > > Things may change when we switch to the master branch after Junyan's > patchset. But for this 0.9.x branch, We may just use these temporary > solutions. > > > -----Original Message----- > > From: Beignet [mailto:[email protected]] On > > Behalf Of Song, Ruiling > > Sent: Friday, September 12, 2014 4:21 PM > > To: Zhigang Gong; Gong, Zhigang > > Cc: [email protected] > > Subject: Re: [Beignet] [PATCH 1/3] GBE: fix multiple files > > compilation > bugs. > > > > > > What kind of non-fatal error? Disable verifier pass can be only a > temporary > > solution. > > > > > + // XXX remove the verifier pass to workaround a non-fatal error. > > > #if LLVM_VERSION_MAJOR == 3 && LLVM_VERSION_MINOR >=5 > > > - FPM.add(createVerifierPass(true)); > > > + //FPM.add(createVerifierPass(true)); > > > #else > > > - FPM.add(createVerifierPass()); > > > + //FPM.add(createVerifierPass()); > > > #endif > > > FPM.add(new TargetLibraryInfo(*libraryInfo)); > > > FPM.add(createTypeBasedAliasAnalysisPass()); > > > -- > > > 1.8.3.2 > > > > > > _______________________________________________ > > > Beignet mailing list > > > [email protected] > > > http://lists.freedesktop.org/mailman/listinfo/beignet > > _______________________________________________ > > Beignet mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/beignet > > _______________________________________________ > > Beignet mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
