LGTM, thanks. -----Original Message----- From: Beignet [mailto:[email protected]] On Behalf Of Zhigang Gong Sent: Wednesday, June 11, 2014 9:40 AM To: Gong, Zhigang Cc: [email protected] Subject: Re: [Beignet] [PATCH] GBE: increase batch size to relax the max reloc restriction.
ping for review. On Tue, Jun 10, 2014 at 09:00:00AM +0800, Zhigang Gong wrote: > The drm will restrict the max reloc to (batch size)/8. > Current batch buffer size is 8K, then the max reloc is 1024. > As the max workgroup size is 1024, if it uses simd16 channel then the > thread_n will be 1024/16 = 64. And if it need to bind > 32 buffers, then the reloc count will be 64*32 which is 2048 and > exceed current limitation. Let's increase the batch size to 16K to > relax this restrication to 2048 relocs. > > Signed-off-by: Zhigang Gong <[email protected]> > --- > src/intel/intel_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/intel_driver.c b/src/intel/intel_driver.c index > 989193a..bb2f9b2 100644 > --- a/src/intel/intel_driver.c > +++ b/src/intel/intel_driver.c > @@ -129,7 +129,7 @@ error: > } > > /* just used for maximum relocation number in drm_intel */ -#define > BATCH_SIZE 0x2000 > +#define BATCH_SIZE 0x4000 > > static void > intel_driver_memman_init(intel_driver_t *driver) > -- > 1.8.3.2 > > _______________________________________________ > Beignet mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
