> -----Original Message----- > From: Song, Ruiling > Sent: Monday, April 28, 2014 3:21 PM > To: Gong, Zhigang; [email protected] > Cc: Gong, Zhigang > Subject: RE: [Beignet] [PATCH v3] GBE: Avoid unecessary dag/liveness > computing at backend. > > --- a/backend/src/backend/gen_program.cpp > +++ b/backend/src/backend/gen_program.cpp > @@ -80,9 +80,12 @@ namespace gbe { > bool limitRegisterPressure; > } codeGenStrategy[] = { > {16, 0, false}, > + {16, 5, false}, > {16, 10, false}, > {8, 0, false}, > + {8, 4, false}, > {8, 8, false}, > + {8, 16, false}, > }; > If there is no special reason, I think you can remove at least one strategy > you > added, either {16, 5, false}, or {8, 4, false}. > > - GBE_DELETE(ctx); > fn->getImageSet()->clearInfo(); > } > + //GBE_DELETE(ctx); > Is this a typo? Why you comment it? Not a typo. I may need to remove it. We will not delete the context here anyway. If there is not a valid kernel, it triggers an assert. Otherwise, the context will be kept and delete at the kernel destructor.
_______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
