Yi,

This is really an efficient way to test the builtin math functions.
Two minor comments here:
1. Could you put all the generated unit test cases to sub-directory of the 
utests?
2. It's better to delete all the generated files when do a make clean.
3. On the auto-generated test cases. It's better to put some statement on the 
top of the file,
just as below:

// This file is generated by ...
// Please don't modify this file manually.

Thanks,
Zhigang Gong.

On Tue, Nov 26, 2013 at 09:14:41PM +0800, Yi Sun wrote:
> File utest_generator.py contain the base class and function for generating 
> test cases.
> File utest_math_gen.py can generate most math function for all the gentype 
> (floatX, intX).
> utest_math_gen.py can be run during cmake.
> 
> Signed-off-by: Yi Sun <[email protected]>
> Signed-off-by: Yangwei Shui <[email protected]>
> 
> diff --git a/utests/CMakeLists.txt b/utests/CMakeLists.txt
> index 5e0bc19..135ea9b 100644
> --- a/utests/CMakeLists.txt
> +++ b/utests/CMakeLists.txt
> @@ -1,10 +1,14 @@
>  INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}
_______________________________________________
Beignet mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/beignet

Reply via email to